On Fri, Jan 14, 2011 at 10:19 PM, Stuart Henderson <[email protected]> wrote:
> On 2011/01/14 20:59, Stuart Henderson wrote:
>> On 2011/01/13 17:35, ramrunner wrote:
>> > ok list.
>> > here is a new port of the newest version of dhex that
>> > has string searching capabilities and some bugfixes.
>> > the maintainer was kind enough to provide that after marcos request.
>> > also the new port has WANTLIB, and -03 flags , but somebody
>> > could just mention it before...
>>
>> - We don't set optimization CFLAGS in a port Makefile, unless there
>> is a specific reason the software is broken with other settings
>> (examples of when it's valid: some software requires -O or -O0
>> otherwise build fails, other software usually involving asm code
>> on i386 may require certain settings to ensure enough registers
>> are available).
>>
>> - Use ${INSTALL_PROGRAM} for a binary, it handles stripping correctly.
>>
>> - Specify the license version before PERMIT_*.
>>
>> - Should honour CC and CFLAGS passed in from the system.
>>
>> updated tgz attached.
>
> bleh, superfluous WRKDIST that I didn't notice earlier; I won't
> bother with a new tarball but I've zapped it from my tree.
The "-Wall" in CFLAGS is superfluous too:
MAKE_FLAGS = CC="${CC}" CFLAGS="${CFLAGS} -std=c99"
should be sufficient. But, apart from this, it's OK for me.
Ciao,
David
