On 16/02/2011 8:03 PM, Stuart Henderson wrote:
On 2011/02/16 01:57, Ingo Schwarze wrote:
In the samba tarball, specifically, generated man(7) pages exist
in two versions each, for example samba.7 and samba.7.crap.
see /usr/ports/net/samba/Makefile; samba.7 is copied to samba.7.crap
and then some expressions that groff-1.15 can't handle are removed
with sed to generate the samba.7 version.

There is no way to fix this quickly.  We will have to update
our ports groff to groff-1.20 post-release, which i intend to
do anyway, then check whether the samba build system picks up
the right version ("samba.7.crap") that works with latest,
shiniest groff.  Don't ask me about the nomenclature.
when groff is updated, this diff can be applied.

Index: Makefile
===================================================================
RCS file: /cvs/ports/net/samba/Makefile,v
retrieving revision 1.132
diff -u -p -r1.132 Makefile
--- Makefile    17 Jan 2011 17:58:03 -0000      1.132
+++ Makefile    16 Feb 2011 09:01:44 -0000
@@ -161,15 +161,6 @@ pre-configure:
  post-extract:
        @cp ${FILESDIR}/krb5-config ${WRKDIR}/bin
        @chmod a+x ${WRKDIR}/bin/krb5-config
-       @for file in ${SAMBA_MANPAGES}/*; do \
-        if [ -f $$file ]; then \
-         cp $$file $$file.crap; \
-         sed -e 's:\\FC::g' -e 's:\\F\[\]::g' -e 's:\.\\\":\ \\\":g' \
-          -e 's:SH-xref:Sx:g' -e 's:\\m\[\]::g' -e 's:toupper:tu:g' \
-          -e 's:\.\.\\\":\\\":g' -e 's:^.tu :\\":g' -e's:\\m\[blue\]::g' \
-          -e's:\\m\[\]::g' $$file.crap>  $$file; \
-        fi; \
-       done

  post-install:
        ${INSTALL_DATA_DIR} ${PREFIX}/share/doc/samba/pdf





Umm, yeah the .crap files are my doing. Historically the samba man pages caused this nice error

fatal error: input stack limit exceeded (probable infinite loop)

and as such we had no man pages. The above was added to make them work with our 
old
intree groff before removal. It's needs revisiting....


Ian McWilliam

Reply via email to