On Thu, Apr 21, 2011 at 06:10:08PM -0500, Amit Kulkarni wrote:
> Hi,
> 
> Please consider the additions to this page. It can go in now because they 
> apply to 4.9. Will somebody confirm? I use this page as reference before 
> submitting.
> 
> Thanks,
> amit
> 
> Index: testing.html
> ===================================================================
> RCS file: /cvs/www/faq/ports/testing.html,v
> retrieving revision 1.6
> diff -u -r1.6 testing.html
> --- testing.html      19 Sep 2010 13:35:40 -0000      1.6
> +++ testing.html      21 Apr 2011 23:03:45 -0000
> @@ -185,20 +185,37 @@
>           and permissions.
>          </ul>
>  
> -      <li><i>package</i>
> -        <ul>
> -         <li>Package creation can break if pkg/PLIST* and/or
> -         pkg/PFRAG* are wrong.</li>
> -        </ul>
>  
>        <li><i>lib-depends-check</i>
> +       <li><i>port-lib-depends-check</i>
>          <ul>
> -         <li>This will check whether all libraries on which the port depends
> +         <li>These will check whether all libraries on which the port depends
>           can be reached through either <tt>LIB_DEPENDS</tt> or 
> <tt>WANTLIB</tt>.
>           The result should be empty. The above variables should be inspected
> -         when you see lines starting "Extra" or "Missing".
> +         when you see lines starting "Extra" or "Missing". If there are 
> +         any problems highlighted they should be fixed before proceeding 
> +         further.
> +        </ul>
> +
> +
> +      <li><i>plist</i>
> +        <ul>
> +         <li>After making sure the output of port-lib-depends-check and 
> +         lib-depends-check is clean, a package can be created (new port)

Ok, it's good but the thing here is `lib-depends-check' is checking
(@wantlib and @depends) integrity against already existing package, if
you use lib-depends-check package will be created by the Ports system,
as it must exist for that target.

However port-lib-depends-check is checking integrity of Makefile
(WANTLIB and LIB_DEPENDS) against ports tree, without need of a binary
package.

Looking at the current version of testing.html, it has proper order how
the package is created by the Ports system. You're change introduce a
list which is out of that order.

Plese re-arange you're text to keep things in more or lest following
order (asterisk is target which is not on testing.html page):

fetch
checksum
extract
patch
configure
build
regress
fake
plist or update-plist(*)
port-lib-depends-check(*)
package
lib-depends-check
install
deinstall


Not all above targets needs to be at the above position, for example
sometime regress needs to be after install, as regress depends on the
package itself.

Would appreciate if other porters double-checked what I wrote.


> +         or updated (existing port). You have to ensure to (re)create 
> +         pkg/PLIST* and/or pkg/PFRAG*.</li>
> +         <li>Sometimes there will be no error if plist target is not updated 
> +         but the package install/uninstall process will be plain wrong.</li>
>          </ul>
>  
> +
> +      <li><i>package</i>
> +        <ul>
> +         <li>Package creation can break if pkg/PLIST* and/or
> +         pkg/PFRAG* are wrong.</li>
> +        </ul>
> +
> +
>        <li><i>install</i>
>          <ul>
>           <li>Packages should install all of the files from their packaging

-- 
best regards
q#

Reply via email to