On 2011/05/08 15:42, Amit Kulkarni wrote:
> 
> I will try to feed your diff upstream and hope it can get integrated
> into RC2. I will cc ports@ on that.

As-is, this isn't suitable for upstream, most OS have GNU grep in
/usr/bin/grep. If you want to send them something, I think the best
approach would be to allow paths for grep/diff to be passed in to
configure, and have it test that they work as expected i.e.
that the GNU REs and diff options are supported, and bail out
with a good error message - I prefer this over automatically
searching for gdiff/ggrep (because then it's clear that a
dependency is required).

> I changed the DESC file to copy the paragraph from their website (inserted
> INRIA, their lab where it wasn't clear who 'us' refers to)...

ah yes I'd forgotten about that bit, thanks, have tweaked this ;-)

> Attaching the complete port for testing.

btw, I think I speak for all porters when I say we strongly
prefer tars that extract into a subdirectory rather than
overwriting files in the current directory.

Attachment: coccinelle.tgz
Description: application/tar-gz

Reply via email to