On 06/13/11 16:31, Brad wrote:
> On 13/06/11 8:21 AM, Nigel Taylor wrote:
>> Hi,
>>
>> transcode make print-package-signature doesn't make pkg_info -S, causing
>> rebuilds unnecessarily. multimedia/xvidcore is required to build but not
>> it's libraries shift from LIB_DEPENDS to BUILD_DEPENDS.
>>
>> Please check and update the port.
>>
>> Regards
>>
>> Nigel Taylor
>
> This is definitely wrong for transcode.
>
>
Hi,
The library isn't listed as a required WANTLIB += xvidcode, so a
RUN_DEPENDS/BUILD_DEPENDS is required rather than a LIB_DEPENDS (or
packaging is wrong for LIB_DEPENDS in not including the package).
Checking the build I find no case of a -lxvidcore, the normal library
linking isn't being used (apart from the configure and that doesn't
count as it doesn't end up in the package) so the current packaging
can't detect the use of the xvidcore library.
Your find pkg_info -S transcode currently doesn't show a dependency on
xvidcore,
pkg_info -S transcode
Information for inst:transcode-1.1.5p7
Signature:
transcode-1.1.5p7,ICE.9.0,SDL.8.0,SM.8.0,X11.15.0,Xau.9.0,Xaw.14.0,Xdmcp.10.0,Xext.12.0,Xmu.10.0,Xpm.8.0,Xt.10.0,Xv.5.0,a52.0.0,avcodec.15.1,avformat.14.1,avutil.8.1,bz2.10.4,c.58.3,dv.5.0,dvdread.4.3,faac-1.26,faac.1.0,ffmpeg-20110408,freetype.17.2,gsm.1.0,iconv.6.0,jpeg-8c,jpeg.64.0,lame-3.98.4,liba52-0.7.4p2,libdv-1.0.0,libdvdread-0.9.7p1,libiconv-1.13p2,libmpeg2-0.5.1p0,libogg-1.2.2,libtheora-1.1.1p0,libvorbis-1.3.2,libxml-2.7.8p2,m.5.3,mp3lame.2.0,mpeg2.0.1,mpeg2convert.0.0,mplayer-20110309p5,ogg.6.1,orc-0.4.3.0,postproc.14.0,pthread-stubs.1.0,pthread.13.1,schroedinger-1.0.2.0,sdl-1.2.13p15,sndio.4.0,sox-14.3.0p0,speex.8.0,theora.3.2,theoradec.1.1,theoraenc.1.2,toolame-0.2lp1,usbhid.3.0,vorbis-tools-1.4.0,vorbis.8.0,vorbisenc.3.1,vorbisfile.6.0,vpx.2.0,x264-20110225,x264.6.0,xcb.2.2,xml2.12.0,z.4.1
The way around this is to use a RUN_DEPENDS and BUILD_DEPENDS (as in
corrected patch below) now xvidcore is included in the signature
pkg_info -Sq transcode-1.1.5p8.tgz
transcode-1.1.5p8,ICE.9.0,SDL.8.0,SM.8.0,X11.15.0,Xau.9.0,Xaw.14.0,
Xdmcp.10.0,Xext.12.0,Xmu.10.0,Xpm.8.0,Xt.10.0,Xv.5.0,a52.0.0,
avcodec.15.1,avformat.14.1,avutil.8.1,bz2.10.4,c.58.3,dv.5.0,
dvdread.4.3,faac-1.26,faac.1.0,ffmpeg-20110408,
freetype.17.2,gsm.1.0,iconv.6.0,jpeg-8c,jpeg.64.0,lame-3.98.4,
liba52-0.7.4p2,libdv-1.0.0,libdvdread-0.9.7p1,libiconv-1.13p2,
libmpeg2-0.5.1p0,libogg-1.2.2,libtheora-1.1.1p0,libvorbis-1.3.2,
libxml-2.7.8p2,m.5.3,mp3lame.2.0,mpeg2.0.1,mpeg2convert.0.0,
mplayer-20110309p5,ogg.6.1,orc-0.4.3.0,postproc.14.0,
pthread-stubs.1.0,pthread.13.1,schroedinger-1.0.2.0,sdl-1.2.13p15,
sndio.4.0,sox-14.3.0p0,speex.8.0,theora.3.2,theoradec.1.1,theoraenc.1.2,
toolame-0.2lp1,usbhid.3.0,vorbis-tools-1.4.0,vorbis.8.0,vorbisenc.3.1,
vorbisfile.6.0,vpx.2.0,x264-20110225,x264.6.0,xcb.2.2,xml2.12.0,
xvidcore-1.3.0,z.4.1
The end package now has the correct dependencies. Previously this
package only worked as there are other dependencies such as mplayer on
xvidcore, which did the job of installing xvidcore.
Regards
Nigel Taylor
Index: Makefile
===================================================================
RCS file: /home/cvs/ports/multimedia/transcode/Makefile,v
retrieving revision 1.41
diff -u -p -r1.41 Makefile
--- Makefile 18 Apr 2011 23:37:07 -0000 1.41
+++ Makefile 13 Jun 2011 17:27:29 -0000
@@ -5,7 +5,7 @@ SHARED_ONLY= Yes
COMMENT= video stream processing tools
DISTNAME= transcode-1.1.5
-REVISION= 7
+REVISION= 8
CATEGORIES= multimedia
MASTER_SITES= ${MASTER_SITE_BERLIOS:=tcforge/}
EXTRACT_SUFX= .tar.bz2
@@ -49,16 +49,17 @@ LIB_DEPENDS= audio/faac \
multimedia/libdv \
multimedia/libtheora \
multimedia/x264 \
- multimedia/xvidcore \
textproc/libxml
RUN_DEPENDS= audio/sox \
audio/vorbis-tools \
audio/toolame \
graphics/ffmpeg \
+ multimedia/xvidcore \
x11/mplayer
-BUILD_DEPENDS+= devel/libtool
+BUILD_DEPENDS+= devel/libtool \
+ multimedia/xvidcore
SEPARATE_BUILD= concurrent
