On Sat, Jun 18, 2011 at 12:47:50PM -0600, Anthony J. Bentley wrote:
> On Tue, Jun 14, 2011 at 5:13 AM, Landry Breuil <[email protected]> wrote:
> > On Fri, Jun 10, 2011 at 11:59:49PM -0600, Anthony J. Bentley wrote:
> >> Hi,
> >>
> >> DMG2IMG is a tool which allows converting Apple compressed dmg
> >> archives to standard (hfsplus) image disk files.
> >> This tool handles zlib and bzip2 compressed dmg images.
> >
> > CFLAGS is wrong, this should be CONFIGURE_ENV=CPPFLAGS=xxxx, and should
> > use ${LOCALBASE} and not hardcode usr/local.
> 
> There is no configure script, just a makefile. I tried
> 
> MAKE_ENV =      CFLAGS+="-I${LOCALBASE}/include -L${LOCALBASE}/lib"

MAKE_FLAGS works, and while here i separated CFLAGS and LDFLAGS..

> (and variants thereof), but it didn't seem to like any of them, still
> not finding the right headers.
> 
> > As for DESTDIRNAME, i've never seen such constructs... shouldnt that be
> > WRKDIR/WRKINST instead ?
> 
> The program attempts to install to ${DESTDIR}${PREFIX}/bin. I recall
> graphics/dpic doing the same thing, and the port for that has its own
> do-install. So maybe this version (attached) is better, especially
> since it already had a post-install for the man page.

As we patch Makefile anyway, let's patch the install target provided by
upstream. while here, fix modes for the binary..

'Fixed' version attached.

Landry

Attachment: dmg2img-fix.tgz
Description: application/tar-gz

Reply via email to