>> - LIB_DEPENDS appears to have some redudant fluff, pango depends on glib, so
>>   no need to depend on glib. cairo depends on png, so no need for png either.

thanks for taking a look. i've removed glib and png dependencies.

>> - could you please look at the systrace warnings during the build? i don't
>>   know if they're harmless, but just to be sure.
>
> I suspect this is most likely to be a mkdir() call, my hunch would be
> to look at the ones in src/main/dounzip.c first.

i'l take a look. thanks for the hint.

>
>> - it links with -lpthread instead of -pthread in several places

hints appreciated here. this might take me a bit of time to work out.

> It's also linking gettext statically now (that's what the removed
> patch-configure lines were fixing), which is especially obvious if you
> --enable-R-shlib (as requested by, and based on a diff from, Sam Smith).

thanks for this! I've included in the latest patch.

> This diff [...] corrects license marker,

i also originally had GPLv2+ because I read answer #1 from the the R
FAQ too quickly (http://cran.r-project.org/doc/FAQ/R-FAQ.html). Later
I realized the "or any later version" applies to that document not to
R itself. The actual project license details are summarized here
http://www.r-project.org/Licenses/ (and also in the FAQ as Q 2.11) so
I think the original GPLv2 that I had is more correct. I've added a
link to the license page in the latest patch.

> ... and enables the shared lib.

So, enabling the shared lib give me the following which I haven't
figured out how to fix yet --

    $ make update-plist
    ...
    WARNING: version mismatch for lib: R (212.2 vs. 0.0)


Newly rolled patch uploaded in text format --
  http://dickman.org/openbsd/patches/math_R.v2.diff

Also gzipped --
  http://dickman.org/openbsd/patches/math_R.v2.diff.gz

Reply via email to