On Sat, Jun 25, 2011 at 03:02:16PM +0100, Mikolaj Kucharski wrote:
> On Sat, Jun 25, 2011 at 03:48:20PM +0200, Marc Espie wrote:
> > > @cd ${.CURDIR}; for i in ${HDRS}; do \
> > > cmp -s $$i ${INCDIR}/$$i || \
> > > ${INSTALL} ${INSTALL_COPY} -m 444 -o $(BINOWN) -g $(BINGRP) $$i
> > > ${DESTDIR}${INCDIR}/; \
> > > echo ${INSTALL} ${INSTALL_COPY} -m 444 -o $(BINOWN) -g $(BINGRP)
> > > $$i ${DESTDIR}${INCDIR}/; \
> > > done
> >
> > Obvious missing DESTDIR in the cmp line.
>
> Correct, but is there a point to have this line anyway?
Those are normal practices, let that line be, tell people to fix the DESTDIR
though which is an obvious bug.