On Mon, Jul 11, 2011 at 11:02 PM, Landry Breuil <[email protected]> wrote: > On Mon, Jul 11, 2011 at 09:17:17PM -0700, Jeremy Evans wrote: >> This patch adds ruby 1.9 support to textproc/ruby-hyperestraier. Like >> most of the existing ruby ports, it allows the 1.8 and 1.9 versions to >> be installed side by side. >> >> Tested on i386. I plan on commit this in a few days and build the >> ruby19 FLAVOR by default unless I hear objections. >> >> No REVISION bump as the ruby 1.8 package is not affected. > > Reads good, but wasn't the ruby19 flavouring handled by ruby.port.mk ?
Only for gem and extconf ports, and this isn't one of those. > Are the two patches coming from or reported upstream ? No. Upstream is dead AFAIK. Hyperestraier is based on QDBM, and the developers have already moved on to the Tokyo Cabinet and Kyoto Cabinet databases. There's a new search engine they made called Tokyo Dysopia, but there isn't a ruby binding for that. The configure changes just remove the hard coding of ruby 1.8 paths so they can be specified by the environment set by the Makefile. The *_LEN and *_PTR macro changes are the only code changes required to work on 1.9, and they are mechanical. On ruby 1.8, the *_LEN and *_PTR macros result in equivalent code. On ruby 1.9 only the *_LEN and *_PTR macros are valid, as the internal structures differ between versions, so ruby extensions that want to be compatible with both 1.8 and 1.9 need to use the *_LEN and *_PTR macros. Jeremy
