On Sun, 4 Sep 2011, Matthias Kilian wrote: > On Sun, Sep 04, 2011 at 08:50:28PM +0200, Donovan Watteau wrote: > > It seems that, for an unknown reason, CONFIG_TREMOR doesn't get enabled. > > Could you do a simple "make configure", and then provide the content of > > config/tremor.h, "grep TREMOR config.mk" and "grep VORBIS config.mk"? > > $ cat config/tremor.h: > #ifndef CONFIG_TREMOR_H > #define CONFIG_TREMOR_H > > #define CONFIG_TREMOR 1 > > #endif > $ grep -E TREMOR\|VORBIS config.mk > CONFIG_VORBIS = n > > > I guess you have audio/tremor installed? > > Yes. > > > Maybe the detection of Tremor is handled better if we don't explicitly > > set CONFIG_TREMOR/CONFIG_VORBIS. But, reading the ./configure script, > > I think we *do* need to set these variables, but I might have > > misunderstood that... > > Without those, I get > > $ cat config/tremor.h > #ifndef CONFIG_TREMOR_H > #define CONFIG_TREMOR_H > > /* #define CONFIG_TREMOR */ > > #endif > $ grep -E TREMOR\|VORBIS config.mk > VORBIS_CFLAGS = -I/usr/local/include > VORBIS_LIBS = -L/usr/local/lib -lvorbisfile -lvorbis -lm -logg > CONFIG_VORBIS = y > > > I still think this should be imported *without* the arm-specific > tweaks and then fixed later, probably upstream. After all, what's > the purpose of that (non-autoconf) configure stuff? It's not as > broken by design as autoconf, but it's still complicated (and > broken). Thanks for your help.
Well, actually, I think we could try one last thing. If it still
doesn't work, then it'd be better to remove the arm-specific tweaks,
of course.
I think the mistake is mine. README says:
If you want to use the Tremor library as alternative for decoding
Ogg/Vorbis files you have to pass CONFIG_TREMOR=y to the configure
script:
$ ./configure CONFIG_VORBIS=y CONFIG_TREMOR=y
Some stuff make Vorbis and Tremor mutually exclusive, but here it
doesn't seem to be the case. I was putting CONFIG_VORBIS=n whilst
it should have been CONFIG_VORBIS=y (= default choice if Vorbis is
found). So Tremor was indeed found, but I was disabling it right
after that with CONFIG_VORBIS=n. Oops. Sorry for that.
The attached port should fix this issue once and for all. It also
documents the new sndio backend in the manpage.
cmus.tar.gz
Description: Binary data
