On Sunday, November 20, 2011 18:27 CET, Timo Myyrä <[email protected]> wrote:
> On Sun, Nov 20, 2011 at 3:20 PM, Sebastian Reitenbach > <[email protected]> wrote: > > > > On Sunday, November 20, 2011 13:52 CET, "Sebastian Reitenbach" > > <[email protected]> wrote: > > > >> Hey Timo, > >> > >> On Sunday, November 20, 2011 12:53 CET, Timo Myyrä <[email protected]> > >> wrote: > >> > >> > Hi, > >> > > >> > Just updated the chicken port at > >> > https://github.com/jasperla/openbsd-wip/tree/master/lang/chicken. > >> > I added fix for hppa in the Makefile but I don't know if there are > > > >> > other archs which would also need the fix. > >> > Otherwise the port seems OK to me, anyone else have opinion about it.> > >> > Not sure if the perl search and replace from Makefile is best way but> > >> > it seems to work. > >> > >> I haven't tested it though, since I don't know really what to do with it > >> ;) but some comments: > >> > >> You should install the docs in the same directory as was with the old > >> version of the port. > > Updated the doc path. > > >> And also you should get rid of the spaces in the html file names as it was > >> in the old version. I had the same problem with www/sogo. You may take a > >> look in the Makefile how I did it there, just in case there is no better > >> way with this port. > >> > > Is this really necessary? The files are currently distributed with > spaces compared to old version. And if I rename them I would need to > scan the HTML files themselves and fix all the links between them. > Seems bit tedious just to get rid of spaces. ah, OK, they link to each other, then its ugly, but you are probably right. Maybe someone else can comment on this. > > >> Did the port really switched to SHARED_ONLY? > >> If you are unsure, change that, and I could try it on a vax. > > Seems to be shared as far as I know. I've seen those .so files, seems to be kind of plugins. But there is also a libchicken.a file, thought it might have been for static linking, so, I don't know.. > > > > > and I forgot: the version number of the SHARE_LIB chicken should not grow > > backwards, the old was 1.0, 0.0 is definitely wrong. You should check the > > header files for API changes. > > Ok, bumped the major version. I'm not 100% sure but diffing chicken.h > showed at least one change and lots of additions so I'd assume major > bump is in order. additions are for minor bumps, changes and removals qualify a major bump, so should be fine then. > > > and instead of this in the PLIST > > @comment lib/libchicken.so > > @lib lib/libchicken.so.${LIBchicken_VERSION} > > @bin lib/libchicken.so.6 > > > > you should just only install the > > @lib/libchicken.so.${LIBchicken_VERSION} > > and get rid of the other two. > > Hmm, how to get rid of these, the make plist phase regenerates the > file when building the port so any changes are overwritten? It must be somewhere in the Makefile, in the install phase. There are probably links or symlinks created. Sebastian > > Timo
