On 2012/02/05 14:05, Alexey Suslikov wrote:
> Hello ports@.
>
> For anyone who'd been interested in recent kamailio.
wrong time for this in-tree, but a few comments from reading your diff:
> -REVISION-main = 2
> +REVISION-main = 0
new version -> remove REVISION lines
> +SHARED_LIBS = kcore 1.0 \
> + kmi 1.0 \
> + ser_cds 0.1 \
> + srdb1 1.0 \
> + srdb2 1.0 \
> + trie 1.0
SHARED_LIBS should start from 0.0 when they're added to a port - this
is not somewhere that you just document what files the port produces,
it is somewhere that you *control* what files the port produces
> +MAKE_ENV = CC=${CC} LDFLAGS="${LDFLAGS} -pthread"
add QUIET=verbose here to unhide the compiler lines, revealing
this beauty which needs fixing...
cc -g -O9 -funroll-loops -Wcast-align -m64 -minline-all-stringops -falign-loops
-ftree-vectorize -fno-strict-overflow -mtune=opteron
> MODULES = devel/gettext
> -WANTLIB-main = c crypto curl db expat pcre pthread ssl xml2
> +WANTLIB-main = c crypto curl db expat pcre pthread ssl xml2 \
> + iconv idn intl ncurses readline z
iconv/intl come from MODULES, use the definitions from gettext.port.mk
don't list them separately
> -# TODO
> -#PSEUDO_FLAVORS += no_radius
I'd kind-of like to leave this as a reminder
/me looks at half-finished radiusclient-ng port languishing in his tree ;-)
> +WANTLIB-carrierroute = confuse iconv intl
same about using MODULES
> +-cfg_target = $(prefix)/$(cfg_dir)
> ++cfg_target = /etc/$(MAIN_NAME)/
don't hardcode /etc, use ${SYSCONFDIR}
> +lib/kamailio/libkcore.so
> +lib/kamailio/libkcore.so.1
this is wrong, should just have the
'@lib lib/kamailio/libkcore.so.${LIBkcore_VERSION}' files and not these
Also the TLS support should be re-added
I've added this to openbsd-wip on github and fixed some of the above -
I can't add new people with direct push access there for now (until Jasper
is back) but if you fork the tree I will take pull requests.
