Hello Stu, thank you for your remarks. Makefile was updated with these corrections. I also added a pkg/MESSAGE (about /dev/pf and sudo).
portfiles : http://devio.us/~suicmez/check_pf_portfiles.tar.gz package : http://devio.us/~suicmez/check_pf-0.1.tgz Have a good day. On Fri, May 4, 2012 at 1:39 PM, Stuart Henderson <[email protected]>wrote: > On 2012/05/04 11:07, Julien Dhaille wrote: > > Hi. > > check_pf is small plugin for nagios, written in C ( > https://github.com/kian). > > Tested on i386. > > > > Critical would be appreciated :) > > > > Thanks > > > > Source : http://devio.us/~suicmez/check_pf-0.1.tar.gz > > Package : http://devio.us/~suicmez/check_pf-0.1.tgz > > Makefile ; distinfo; pkg/DESCR ; pkg/PLIST : > > http://devio.us/~suicmez/portfiles_check_pf.tar.gz > > > > -- > > Julien > > Porting comments:- > > - use INSTALL_PROGRAM not INSTALL_SCRIPT > > - port should honour CC and CFLAGS passed in the environment/mk.conf > (typically pass via MAKE_ENV or MAKE_FLAGS) > > - I would use "pf(4)" or "PF" in the comment to indicate that it's > specifically for PF and not a generic "packet filter" > > - DESCR shouldn't include version number information etc and shouldn't > have the blank line at the end, I would suggest something like: > > -- -- -- > check_pf is a Nagios plugin to check the number of entries in the > pf(4) (OpenBSD packet filter) state table, and compares this number > against the WARNING and CRITICAL thresholds, which may be specified > on the command-line or omitted to use defaults based on the current > hard state limit. > -- -- -- > > > Other comments:- > > - this is pretty useful (though in -current there's another way > of getting the state-table information; via snmpd) > > - there needs to be some handling of permissions, at least instructions > to the user on how to handle it without giving the _nagios or _icinga > user blanket access to /dev/pf, even if that's read-only... sudo might > be appropriate for this. > > -- Julien Dhaille
