On Sun, May 13, 2012 at 02:00:38PM +0200, Thomas Pfaff wrote: > ogg123 in audio/vorbis-tools will abort if interrupted or it reaches > the end of a file because it tries to unlock an already unlocked mutex. > > I suppose the better way to fix this is to figure out why it tries to > unlock the mutex twice and correct that, though I'm going to leave that > to someone else if this quick fix is not satisfactory ;-)
I think this particular issue should be fixed, not worked around. > Index: Makefile > =================================================================== > RCS file: /cvs/ports/audio/vorbis-tools/Makefile,v > retrieving revision 1.43 > diff -u -p -r1.43 Makefile > --- Makefile 29 Mar 2012 13:38:13 -0000 1.43 > +++ Makefile 13 May 2012 11:19:04 -0000 > @@ -3,6 +3,7 @@ > COMMENT= play, encode, and manage Ogg Vorbis files > > DISTNAME= vorbis-tools-1.4.0 > +REVISION= 0 > CATEGORIES= audio > HOMEPAGE= http://www.vorbis.com/ > > Index: patches/patch-ogg123_status_c > =================================================================== > RCS file: patches/patch-ogg123_status_c > diff -N patches/patch-ogg123_status_c > --- /dev/null 1 Jan 1970 00:00:00 -0000 > +++ patches/patch-ogg123_status_c 13 May 2012 11:19:04 -0000 > @@ -0,0 +1,11 @@ > +$OpenBSD$ > +--- ogg123/status.c.orig Wed Jan 27 05:14:11 2010 > ++++ ogg123/status.c Sun May 13 12:51:36 2012 > +@@ -339,6 +339,7 @@ void status_deinit () > + > + void status_reset_output_lock () > + { > ++ pthread_mutex_trylock(&output_lock); /* XXX may already be unlocked */ > + pthread_mutex_unlock(&output_lock); > + } > + > -- Antoine
