On Sat, Jun 30, 2012 at 08:54:56AM +0200, Landry Breuil wrote: > On Fri, Jun 29, 2012 at 11:20:32PM -0400, Stuart Cassoff wrote: > > Here are the diffs, minus xcircuit which has already been > > taken care of by someone with less than infinite patience. :) > > They can also be found in cvs:~stu/diffs. > > I can take maintainer of misc/remind from kevlo@ if that's ok with him. > > I can also take databases/pgtcl; the listed mainter hasn't responded. > > Isn't two the number of OKs I need per port? > > one will be enough for such simple things :) otherwise you'll wait > forever.. > > Only a few remarks : > - i've seen a tcl8.5 (or tcl85) in WANTLIB for pgtcl; use MODTCL_WANTLIB > - wait a few days to see if kevlo replies then take maintainership for > remind. That can still be done in a later commit... > - can you add comments to new patches explaining what they do (when it's > not totally obvious, ie not for changing install paths etc..)
Oh, and misc/tkrat doesn't properly handle SHARED_LIBS. There shouldbe a LIBratatosk_VERSION used instead of hardcoding 2.1 (and in PFRAG.shared), or it shouldnt be versionned at all if it's not meant to be linked against (ie "plugin" for tk ?) Landry > > On 06/28/12 14:46, Stuart Henderson wrote: > > > On 2012/06/21 10:43, Stuart Cassoff wrote: > > >> I'm waiting for a few ok's. > > >> This is what I have so far. > > >> > > >> Stu > > >> > > >> > > >> tcl.port.mk: > > >> cad/xcircuit: > > >> databases/pgtcl: > > >> devel/vtcl: > > >> devel/nagelfar: sebastia@ > > >> lang/eagle: > > >> mail/tkrat: > > >> misc/cbb: sthen@ > > >> misc/remind: > > >> x11/byzi: sthen@ > > >> x11/dbus-tcl: landry@ > > >> x11/dbus-intf: landry@ > > >> > > > > > > Any problem with committing the ones you already have OKs for? > > > It would be helpful to repost diffs for the others.. > > > > > > > > > > > > >
