On Sat, Jun 30, 2012 at 08:15:06PM +0200, Marc Espie wrote:
> 
> Not necessarily, the thing to do is to see in the code what those tests 
> lead to, whether it will actually bring something to OpenBSD, and then
> decide whether we want to disable the tests or not.

Well, looking at the code, this is beyond my expertise to know is it
okay to disable libexecinfo or libmagic in different parts of gcc..


In gcc-4.6.3 sources I see only following files which include <magic.h>

./libjava/java/net/natVMURLConnection.cc
./libjava/classpath/native/jni/java-net/java_net_VMURLConnection.c

In .cc file it looks to me that libmagic.so is dlopen'ed and used in
java::net::VMURLConnection::guessContentTypeFromBuffer()

In .c file I don't see the code using dlopen for libmagic but
function Java_java_net_VMURLConnection_guessContentTypeFromBuffer() uses
it libmagic functions.

Then here is the list of files which include <exeinfo.h>

./libgfortran/runtime/backtrace.c
./libstdc++-v3/include/profile/impl/profiler_node.h
./libmudflap/mf-runtime.c
./boehm-gc/os_dep.c


Does anyone know / can judge is it safe to disable libexecinfo or
libmagic in gcc port? Or, can anyone actually reproduce build failure of
gcc-4.6 with libexecinfo / libmagic installed? I would probably have a
look how this looks in gcc-4.7, maybe it's affected as well.


# cd /usr/ports/lang/gcc/4.6 && make show=PKGNAMES
gcc-4.6.3p3 g95-4.6.3p3 gobjc-4.6.3p3 gcj-4.6.3p4 g++-4.6.3p5
libstdc++-4.6.3p3 gnat-4.6.3p3 gccgo-4.6.3p3


Below patch inlined again.


Index: Makefile
===================================================================
RCS file: /cvs/ports/lang/gcc/4.6/Makefile,v
retrieving revision 1.27
diff -u -r1.27 Makefile
--- Makefile    21 Jun 2012 13:56:57 -0000      1.27
+++ Makefile    1 Jul 2012 14:38:26 -0000
@@ -107,6 +107,8 @@
 
 EXTRA_ENV += am_cv_func_iconv=no JAR=no
 EXTRA_ENV += ac_cv_prog_M4=/usr/bin/m4
+EXTRA_ENV += ac_cv_header_execinfo_h=no
+EXTRA_ENV += ac_cv_header_magic_h=no
 MAKE_FLAGS +=   ac_cv_path_mkdir=/bin/mkdir
 
 CONFIGURE_ENV += ${EXTRA_ENV}



OpenBSD 5.2-beta (GENERIC.MP) #299: Tue Jun 26 23:12:21 MDT 2012
    dera...@i386.openbsd.org:/usr/src/sys/arch/i386/compile/GENERIC.MP

-- 
best regards
q#

Reply via email to