On Thu, Aug 16, 2012 at 7:56 PM, Stuart Henderson <s...@spacehopper.org> wrote: > On 2012/08/16 13:52, Jonathan Matthew wrote: >> Hi, >> >> This updates leveldb from an svn snapshot to release 1.5.0. >> >> One thing I'm not sure about is that I'm using upstream's shared library >> major/minor numbers rather than setting it to 0.1 or something. > > We use our own versioning for this, it looks like they are just using > shared-library numbering based on the release version number. Please either > confirm whether there are ABI changes, or just bump the major i.e. > SHARED_LIBS=leveldb 1.0 > > More info at http://www.openbsd.org/faq/ports/specialtopics.html#SharedLibs
There were some API changes since the previous snapshot, things like changing return types of C++ class methods, enough that I think it's safest to just bump it. >> +Skip checks for <cstdatomic>, snappy and tcmalloc. We don't >> +have any of these, and with our current binutils, c++ -o /dev/null >> +deletes /dev/null, which is kind of bad. > > fun! > > Unfortunately gmail mangled your diff (at least tabs->spaces) so it > doesn't apply, as this is ports@ rather than the other lists, you could > send it as an attachment if necessary.. Sorry about that. Updated diff is attached this time. Thanks for taking a look.
leveldb-update.diff
Description: Binary data
