On Wed, Nov 28, 2012 at 09:24:18PM +0100, Landry Breuil wrote:
> Comments portswise :
> 
> - this is not the way we fix the shebang for python scripts. see
>   python module and MODPY_ADJ_FILES.
> - no need to RUN_DEPENDS on www/webkit, since you already LIB_DEPENDS on
>   it. and for gtk2, no need to use 'www/webkit,' the extra comma is
> useless.

I updated the port, see attachment. BTW, is the gtk2 flavor really needed? I
would happily drop it if nobody is going to use it. Doing so would also
require less patching of source, which is a significant benefit IMO.

On Wed, Nov 28, 2012 at 09:26:44PM +0100, Landry Breuil wrote:
> and added to that, share/uzbl/{docs,examples} is usually not the way we
> do things, rather share/{doc,examples}/uzbl.

I initially tried to make it this way, and even succeeded, but I ended up with
quite a lot of patches. Furthermore, the content of "examples" is not exactly
the examples one would expect; it is a set of scripts that are loaded from the
program unless overriden by user.

Effectively, "fixing" the layout would turn into maintenance pain, as the
"share/uzbl/examples" part of the path is hardcoded in several places and IIRC
in 3rd party scripts on Uzbl wiki.


BTW, the port has several optional hidden dependencies - the scripts uzbl
relies upon invoke zenity and dmenu. These dependencies are easy to override
in user configuration, and even if not done so, they are only required for
several features (bookmarks, namely). How should I manage these dependencies?
In pkg/README? How verbose should I be about them?

-- 
Dmitrij D. Czarkoff

Attachment: uzbl-port.tar.gz
Description: application/tar-gz

Reply via email to