On Mon, Dec 24, 2012 at 10:15:43PM -0700, Anthony J. Bentley wrote:
> Hi,
>
> Attached is a port for xournal-0.4.7.
I love it. I was wondering if something like this existed.
> ok?
The only comment I have is, the HTML manual is in
${PREFIX}/xournal/html-doc and not where we would usually put it, ie.
${PREFIX}/share/doc/xournal.
The build system is not fine-grain enough to use --docdir= and I also
notice that the HTML manual shares the pixmaps that the application
itself uses (via a symlink).
If we are in agreement that the docs should be moved, we could try
something like:
diff -urNa xournal/Makefile xournal.new/Makefile
--- xournal/Makefile Tue Dec 25 05:07:26 2012
+++ xournal.new/Makefile Tue Dec 25 14:22:10 2012
@@ -33,4 +33,8 @@
INSTALL_TARGET = install desktop-install
+post-install:
+ mv ${PREFIX}/share/xournal/html-doc/ ${PREFIX}/share/doc/xournal
+ ln -sf ${LOCALBASE}/share/xournal/pixmaps
${PREFIX}/share/doc/xournal/pixmaps
+
.include <bsd.port.mk>
diff -urNa xournal/pkg/PLIST xournal.new/pkg/PLIST
--- xournal/pkg/PLIST Tue Dec 25 04:36:29 2012
+++ xournal.new/pkg/PLIST Tue Dec 25 14:18:12 2012
@@ -1,6 +1,10 @@
@comment $OpenBSD$
@bin bin/xournal
share/applications/xournal.desktop
+share/doc/xournal/
+share/doc/xournal/manual.html
+share/doc/xournal/pixmaps
+share/doc/xournal/screenshot.png
share/icons/hicolor/scalable/apps/xournal.svg
share/icons/hicolor/scalable/mimetypes/gnome-mime-application-x-xoj.svg
share/icons/hicolor/scalable/mimetypes/xoj.svg
@@ -9,10 +13,6 @@
share/mimelnk/application/
share/mimelnk/application/x-xoj.desktop
share/xournal/
-share/xournal/html-doc/
-share/xournal/html-doc/manual.html
-share/xournal/html-doc/pixmaps
-share/xournal/html-doc/screenshot.png
share/xournal/pixmaps/
share/xournal/pixmaps/black.png
share/xournal/pixmaps/blue.png
What do you think?
--
Best Regards
Edd Barrett
http://www.theunixzoo.co.uk
