On Fri, Jan 04, 2013 at 09:45:53AM +0000, Stuart Henderson wrote:
> On 2013/01/04 15:11, Alexandr Shadchin wrote:
> > Hi,
> > 
> > This update package tkdiff to the latest release 4.2.
> > Tested on amd64.
> > 
> > Comments ? OK ?
> 
> > -V=         4.1.4
> > -DISTNAME=  tkdiff-${V}-unix
> > -PKGNAME=   ${DISTNAME:S/-unix//}
> > -REVISION = 0
> > +V=         4.2
> > +DISTNAME=  tkdiff-${V}
> ...
> > +WRKDIST=   ${WRKDIR}/${PKGNAME:S/-${V}/-unix/}
> 
> this is more complex than needed; these lines can all be replaced with:
> 
> DISTNAME=     tkdiff-4.2
> WRKDIST=      ${WRKDIR}/tkdiff-unix
> 
> also license marker should be GPLv2+ ("GPLv2 or newer").
> 

I agree, so better. Thanks.

-- 
Alexandr Shadchin

Index: Makefile
===================================================================
RCS file: /cvs/ports/devel/tkdiff/Makefile,v
retrieving revision 1.11
diff -u -p -r1.11 Makefile
--- Makefile    23 Oct 2012 09:39:51 -0000      1.11
+++ Makefile    4 Jan 2013 09:54:35 -0000
@@ -2,17 +2,14 @@
 
 COMMENT=       graphical front-end to the diff program
 
-V=             4.1.4
-DISTNAME=      tkdiff-${V}-unix
-PKGNAME=       ${DISTNAME:S/-unix//}
-REVISION =     0
+DISTNAME=      tkdiff-4.2
 CATEGORIES=    devel sysutils
 
 HOMEPAGE=      http://tkdiff.sourceforge.net/
 
 MAINTAINER=    Vlad Glagolev <[email protected]>
 
-# GPL
+# GPLv2+
 PERMIT_PACKAGE_CDROM=  Yes
 PERMIT_PACKAGE_FTP=    Yes
 PERMIT_DISTFILES_CDROM=        Yes
@@ -25,6 +22,8 @@ RUN_DEPENDS=  ${MODTK_RUN_DEPENDS}
 
 NO_BUILD=      Yes
 NO_REGRESS=    Yes
+
+WRKDIST=       ${WRKDIR}/tkdiff-unix
 
 do-configure:
        @${MODTCL_WISH_ADJ} ${WRKSRC}/tkdiff
Index: distinfo
===================================================================
RCS file: /cvs/ports/devel/tkdiff/distinfo,v
retrieving revision 1.3
diff -u -p -r1.3 distinfo
--- distinfo    24 Nov 2007 12:52:51 -0000      1.3
+++ distinfo    4 Jan 2013 09:54:35 -0000
@@ -1,5 +1,2 @@
-MD5 (tkdiff-4.1.4-unix.tar.gz) = +QT7u3GrKrU5D3R+bBEU7g==
-RMD160 (tkdiff-4.1.4-unix.tar.gz) = HNm+BH7sbF7bUDUDgpoXoeS7DwA=
-SHA1 (tkdiff-4.1.4-unix.tar.gz) = tEOGzeT/Rs/w7lY92W0AT+gCiUM=
-SHA256 (tkdiff-4.1.4-unix.tar.gz) = 
zZNSPhSAEptu3sb8CsEMtYAjs1xRE0ncq1O+xQe9uKc=
-SIZE (tkdiff-4.1.4-unix.tar.gz) = 89870
+SHA256 (tkdiff-4.2.tar.gz) = c0u0FxhMEAcutk6NJ0JFM45Bt/3v9mG17zDonz46o1c=
+SIZE (tkdiff-4.2.tar.gz) = 92063

Reply via email to