On 2013-02-09 08:39, Marc Espie wrote:
On Fri, Feb 08, 2013 at 11:40:15AM -0500, Brian Callahan wrote:
+# This will fail if no_nautilus is found in FLAVOR, so make sure we don't
+# do it if it is.
+.if !${FLAVOR:L:Mno_nautilus}
        rm ${PREFIX}/lib/nautilus/extensions-${MAJ_V}/*.la

wrong on two counts.

- we stopped :L flavors about a year ago. There's no reason to allow mixed
cases there, and it confuses other tools.

Aren't there still a lot of ports that use this?

- no_nautilus is a pseudo-flavor. You don't EVER test for pseudo-flavors
directly.   Read bsd.port.arch.mk(5).

you should test on
.if ${BUILD_PACKAGES:M-nautilus}
instead.

Fine please fix it then.
ok aja

--
Antoine

Reply via email to