On 03/04/13 13:25, Dmitrij D. Czarkoff wrote: > On Wed, Jan 30, 2013 at 04:05:28PM +0300, Kirill Bychkov wrote: >> Hi. >> This is a port of tkabber-0.11.1, Tk Jabber client. It was sent to >> ports by Anton Yabchinskiy in Nov 200 and by Dmitrij Czarkoff four >> years later in Nov 2012. >> I'm using it on i386 and amd64 since it was first submitted to >> ports@ by Anton. >> This is reworked port, partly based on a work of previous submitters. >> >> Comments? OKs?
> > The port builds and runs fine. Still I would suggest the following changes: > As I mentioned in my last message, I get crashes when trying to login to a server. Mind you, I don't know jabber well, so any tips are welcome. > ============================================================================== > --- a/net/tkabber/base/pkg/README Mon Mar 04 18:24:27 2013 +0100 > +++ b/net/tkabber/base/pkg/README Mon Mar 04 19:24:50 2013 +0100 > @@ -11,4 +11,3 @@ > * textproc/ispell (spell checking) > * x11/tkcon (Tk console) > * x11/tktray (iconify Tkabber) > -* x11/xosd (OSD support) Why not just have these as RUN_DEPENDS? Give the user the maximum experience. > About PLIST change: "tkabber-khim" plugin uses bundled KHIM package, which > requires Tk 8.4. As I get it, KHIM is now a part of tklib, so I think it would > be better to comment the bundled KHIM out and suggest "devel/tklib" dependency > in README then to tie the package to Tk 8.4. > Thanks for spotting this. It would be greatly appreciated if existing packages (like KHIM, part of tklib) could be used instead of the bundled ones. I also notice a TclXML in there, maybe that can be excised as well? KHIM doesn't need 8.4. Nothing needs 8.4. [package require Tcl 8.4] tends to mean *minumum* 8.4. Tkabber seems fine in 8.6. Tcl script-only packages should run fine under 8.[56]. Tcl extensions compiled against 8.5 should be [load]able into 8.6. 8.4 is the past. 8.5 is the present. 8.6 is the future. Let's look to the future. Stu
