On 2013/03/22 15:58, Dmitrij D. Czarkoff wrote:
> Hello!
> 
> The attached port is an optional dependency of lit2epub script from
> textproc/ebook-tools. It converts Microsoft Reader's *.lit files to OEBPS
> packages.
> 
> -- 
> Dmitrij D. Czarkoff

having tried building it yet, but comments from reading:-

> PKGNAME =               clit-1.8

delightful naming ;)

> # GPLv2

"or any later version" -> GPLv2+

> PERMIT_PACKAGE_CDROM =  drm (see http://www.convertlit.com/legal.php)

not sure if this is really necessary?

> MASTER_SITES =          ${HOMEPAGE} http://libtom.org/files/
> EXTRACT_SUFX =          .zip
> DISTFILES =             ${DISTNAME}src${EXTRACT_SUFX} \
>                         ltm-0.42.0${EXTRACT_SUFX}
..snip..
> do-build:
>         cd ${WRKSRC}/libtommath-0.42.0 && ${MAKE_ENV} ${GMAKE} libtommath.a

looks like it should be two separate ports

>         cd ${WRKSRC}/lib && ${MAKE_ENV} ${GMAKE}
>         cd ${WRKSRC}/${DISTNAME} && ${MAKE_ENV} ${GMAKE}

use ${MAKE_PROGRAM} not ${GMAKE}.

> do-install:
>         install -m0755 ${WRKSRC}/${DISTNAME}/clit ${PREFIX}/bin/clit

${INSTALL_PROGRAM}

> -CFLAGS=-funsigned-char -Wall -O2 -I ../libtommath-0.30/ -I ../lib -I 
> ../lib/des -I .^M
> +CFLAGS=-funsigned-char -Wall -O2 -I ../libtommath-0.42.0/ -I ../lib -I 
> ../lib/des -I .^M

don't hardcode -O2, instead pass CFLAGS across from the port Makefile;
maybe do this in the port: MAKE_FLAGS= COPTFLAGS="${CFLAGS}", and then patch
the above line to use ${COPTFLAGS} instead of -O2.

the -I's would need adjusting for libtommath to be in a separate port.

avoid patching files with dos line endings; in this case as it uses zip
files you may be able to use one of these to convert during extraction

UNZIP=  unzip -a

or

UNZIP=  unzip -aa

(in the general case you can use a pre-patch target to convert the line 
endings.)

>  clit: clit.o hexdump.o drm5.o explode.o transmute.o display.o utils.o 
> manifest.o ../lib/openclit.a ^M
> -       gcc -o clit $^  ../libtommath-0.30/libtommath.a^M
> +       gcc -o clit $^  ../libtommath-0.42.0/libtommath.a^M

don't hardcode gcc, use ${CC}. should also honour CFLAGS.
 

Reply via email to