On Thu, Apr 18, 2013 at 11:49:24PM +0100, Stuart Henderson wrote: > On 2013/04/18 22:40, Alexey E. Suslikov wrote: > > Stuart Henderson <sthen <at> openbsd.org> writes: > > > > > slightly tweaked version attached: diff against your version below. > > > notably I moved the primary category to telephony/ which I think makes > > > sense - net/ is fairly huge so I'd like to avoid putting new ports > > > there if there's a good alternative. > > > > > > would anyone like to give me an OK to import this? > > > > ping. > > > > kannel is not a software mere mortals daily use, so receiving > > grounded OKs maybe problematic. > > > > Stuart, could you please commit this? Me and Roman use various > > versions of this port on heavy loaded systems during many months, > > if not years. > > > > No I cannot commit it. I need an OK.
Some comments : cant the MACHINE/MACHINEWSP stuff be done via a perl -pi subst instead of having so many patches just for that ? be extra careful with the time_t patches, esp since 64-bits time_t is around the corner. the enable/kannelctl scripts are a bit cumbersome imo - all that could be done with two rc scripts, and be simpler. Here, there are too many indirections, with the enable/disable stuff etc. Unless the code itself really relies on the presence/use of those scripts.. Landry
