Den 9. juni 2013 kl. 17:07 skrev Zé Loff <[email protected]>:
>> please find below a simple diff to add cursors keys to x11/dwm.
>> Objections? OKs?
>
> Since this isn't on the upstream code,
... and probably never will be.
> and since dwm is meant to be
> configured/customized by editing config.def.h
This is what the patch does.
> (and built/installed from
> source,
This is what the port does.
> instead of installed as a binary),
So, you want to drop the package,
because everyone is supposed
to compile dwm on their own?
> I'd say this falls into the
> 'customisation' category, and shouldn't be here.
We already have several of such
'customizations' in various ports.
Sometimes upstream defaults
are not very useful.
Regards,
Joerg
>> Index: Makefile
>> ===================================================================
>> RCS file: /cvs/ports/x11/dwm/Makefile,v
>> retrieving revision 1.24
>> diff -u -p -r1.24 Makefile
>> --- Makefile 11 Mar 2013 11:46:09 -0000 1.24
>> +++ Makefile 9 Jun 2013 13:35:54 -0000
>> @@ -3,6 +3,7 @@
>> COMMENT= dynamic window manager
>>
>> DISTNAME= dwm-6.0
>> +REVISION= 0
>>
>> CATEGORIES= x11
>>
>> Index: patches/patch-config_def_h
>> ===================================================================
>> RCS file: /cvs/ports/x11/dwm/patches/patch-config_def_h,v
>> retrieving revision 1.9
>> diff -u -p -r1.9 patch-config_def_h
>> --- patches/patch-config_def_h 9 Jul 2012 16:33:40 -0000 1.9
>> +++ patches/patch-config_def_h 9 Jun 2013 13:35:54 -0000
>> @@ -1,6 +1,6 @@
>> $OpenBSD: patch-config_def_h,v 1.9 2012/07/09 16:33:40 zinke Exp $
>> --- config.def.h.orig Mon Dec 19 16:02:46 2011
>> -+++ config.def.h Sat Jul 7 22:28:18 2012
>> ++++ config.def.h Sun Jun 2 13:03:39 2013
>> @@ -1,13 +1,13 @@
>> /* See LICENSE file for copyright and license details. */
>>
>> @@ -40,3 +40,19 @@ $OpenBSD: patch-config_def_h,v 1.9 2012/
>>
>> static Key keys[] = {
>> /* modifier key function argument */
>> +@@ -55,11 +57,15 @@ static Key keys[] = {
>> + { MODKEY|ShiftMask, XK_Return, spawn, {.v =
>> termcmd } },
>> + { MODKEY, XK_b, togglebar, {0} },
>> + { MODKEY, XK_j, focusstack, {.i = +1 } },
>> ++ { MODKEY, XK_Down, focusstack, {.i = +1 }
>> },
>> + { MODKEY, XK_k, focusstack, {.i = -1 } },
>> ++ { MODKEY, XK_Up, focusstack, {.i = -1 }
>> },
>> + { MODKEY, XK_i, incnmaster, {.i = +1 } },
>> + { MODKEY, XK_d, incnmaster, {.i = -1 } },
>> + { MODKEY, XK_h, setmfact, {.f = -0.05}
>> },
>> ++ { MODKEY, XK_Left, setmfact, {.f =
>> -0.05} },
>> + { MODKEY, XK_l, setmfact, {.f = +0.05}
>> },
>> ++ { MODKEY, XK_Right, setmfact, {.f =
>> +0.05} },
>> + { MODKEY, XK_Return, zoom, {0} },
>> + { MODKEY, XK_Tab, view, {0} },
>> + { MODKEY|ShiftMask, XK_c, killclient, {0} },
>
> --