Stuart Henderson <st...@openbsd.org> writes: > On 2013/07/14 09:03, Jérémie Courrèges-Anglas wrote: >> "Gonzalo L. R." <gonz...@x61.com.ar> writes: >> >> > er, point me out by jca@ webkit already have >> > >> > devel/libsoup>=2.42.0 \ >> > >> > So the first diff is ok. >> >> Looks fine to me, ok jca@. >> >> Looking at the Makefile, upstream explicitely links against gtk3, gnutls >> and libsoup. I suggest amending LIB_DEPENDS: > > I think this is unnecessary, this is only needed for static lib arch - > vax/m88k are never going to run webkit.
It's just about acknowledging that this port directly uses (and thus depends on) those libraries; it's not about trying to make it build anywhere. Eg. currently gnutls is brought in by: webkit,gtk3 -> libsoup -> glib2-networking -> gnutls which I find funny, looking at the number of gnutls_* functions calls in the xombrero sources. I think it's a matter of personal taste, and I'm not going to bother anyone about this. I'm already quite happy to see that xombrero seems quite more stable than it was last week. :) >> --- Makefile.2 Sun Jul 14 08:58:49 2013 >> +++ Makefile Sun Jul 14 08:58:21 2013 >> @@ -22,7 +22,10 @@ >> >> MASTER_SITES= >> http://opensource.conformal.com/snapshots/xombrero/ >> >> -LIB_DEPENDS= www/webkit,gtk3 >> +LIB_DEPENDS= devel/libsoup>=2.4.2 \ >> + security/gnutls \ >> + www/webkit,gtk3 \ >> + x11/gtk+3 >> RUN_DEPENDS= devel/desktop-file-utils >> >> # webkit browsing >> > -- Jérémie Courrèges-Anglas PGP Key fingerprint: 61DB D9A0 00A4 67CF 2A90 8961 6191 8FBF 06A1 1494
