On Fri, Aug 30, 2013 at 10:56:42PM +0200, Stefan Sperling wrote: > There are plenty of random() warnings in the build. > Do you think it's worth fixing them and pushing patches upstream, > making these tools use arc4random() if available?
I know, that's the next thing on my list. But I wanted to get the current port commited first, so I can work in tree. Fernando Gont already asked for feedback, getting it upstream should be easy. > In the Makefile, I'd remove a few of the empty lines between > variable declarations. My style is to follow exacly what is in /use/ports/infrastructure/templates/Makefile.template including empty lines. If we want less useless empty lines they should be removed there. Otherwise I would have to think wether it is nice to have a new line here and there for every port. bluhm
