> > > That is a pretty useless readme imho....
> 
> I disagree as it does show the user how to set the interface..
> 
> > Maybe it's better to have an rc script with default flags and no readme. 
> > The new diff works as long as there is an egress interface.
> 
> It's useful to have this as a default, but I think the instructions are
> still needed as this might get the wrong egress interface (e.g. for
> people who have default IPv4 and IPv6 routes pointing over different
> interfaces and the "wrong" one is first - or, uh, no interface if it
> uses dhcpd and the server is down ;-)

Well people are supposed to read doc and not blindly run stuffs.
Anyway if you really care about it, just bring it back but this part is totally 
redundant imho:

+More options can be found in darkstat's manual page. To let it start at
+boot time darkstat needs to be added to "pkg_scripts" in
+rc.conf.local(8).

> > Index: Makefile
> > ===================================================================
> > RCS file: /cvs/ports/net/darkstat/Makefile,v
> > retrieving revision 1.20
> > diff -u -p -r1.20 Makefile
> > --- Makefile    11 Oct 2013 17:23:16 -0000      1.20
> > +++ Makefile    14 Oct 2013 20:53:04 -0000
> > @@ -3,6 +3,7 @@
> >  COMMENT=               network statistics gatherer with graphs
> >  
> >  DISTNAME=              darkstat-3.0.717
> > +REVISION=              1
> 
> not really important, but 0 is normal for the first REVISION after
> a version update.
> 
> > +#
> > +# $OpenBSD$
> > +
> > +egress_if=$( ifconfig egress 2>/dev/null | head -1 | cut -d : -f 1 )
> > +
> > +daemon="/usr/local/sbin/darkstat"
> > +daemon_flags="-i $egress_if -b 127.0.0.1 --syslog"
> > +
> > +. /etc/rc.d/rc.subr
> > +
> > +rc_reload=NO
> > +
> > +rc_cmd $1
> > 
> 

-- 
Antoine

Reply via email to