On 2013/11/23 21:23, William Yodlowsky wrote:
> On 20 November 2013 at 23:41, William Yodlowsky <[email protected]> wrote:
> > - security update to 1.4.4 and 1.5.7 (CVE-2013-4547)
> > - naxsi update to 0.53 and reflect the move to github
> > - enable the new auth_request_module for the devel branch
> > 
> > ok?
> 
> ping.  Is the distfile handling too complicated?  Or ok?

Not tested as I don't use the ports version of nginx anywhere
and the lack of chroot means it isn't a drop-in replacement for base
nginx for a quick test, but comments from reading:

> >  MASTER_SITES=      http://nginx.org/download/
> >  MASTER_SITES0=     http://dropbox.eait.uq.edu.au/uqdgwynn/distfiles/
> > -MASTER_SITES1 =    http://naxsi.googlecode.com/files/
> > +MASTER_SITES1 =    https://github.com/nbs-system/naxsi/archive/

mix of "FOO=" and "FOO ="

> > -CONFIGURE_ARGS =   --add-module=${WRKSRC}/../naxsi-core-0.49/naxsi_src/
> > +CONFIGURE_ARGS =   --add-module=${WRKSRC}/../naxsi-${NAXSIV}/naxsi_src/

for consistency, why not handle this the same way as other modules,
i.e. mv it to a fixed name in pre-patch?

(these aren't show-stoppers for the update, which I'm basically ok
with, but would be nice to have sometime.)

> > @@ -65,7 +65,8 @@
> >  LUADISTFILES+=             simpl-ngx_devel_kit-v0.2.17-0-gbc97eea.tar.gz:0
> >  LUADISTFILES+=             lua-nginx-module-${LUAV}.tar.gz:0
> >  SUBSTFILES=                conf/nginx.conf
> > -NAXSIDISTFILES +=  naxsi-core-0.49.tgz:1
> > +NAXSIV=                    0.53-1
> > +NAXSIDISTFILES +=  
> > naxsi-${NAXSIV}${EXTRACT_SUFX}{${NAXSIV}${EXTRACT_SUFX}}:1

not related to the port update, but I suppose we are going to have
to put up with more of this mess with googlecode shutting down file
distribution, damn the people using it to distribute warez/ebookz. :(

Reply via email to