Giovanni Bechis <[email protected]> wrote:
> pre-configure:
> ${SUBST_CMD} ${WRKSRC}/Makefile
> + @perl -pi -e 's/@\$$\(/\$$\(/g' ${WRKSRC}/Makefile \
> + ${WRKSRC}/bk/Makefile ${WRKSRC}/iniparser-2.17/Makefile
Hmm. You still have chunks to the same effect in patch-Makefile.
> +- struct timeb timeNow;
> +- ftime(&timeNow);
> ++ struct timeval timeNow;
> ++ gettimeofday(&timeNow, NULL);
> +
> +- if(timeNow.time - volInfo->lastTimeCalledProgress.time >= 1 ||
> +- timeNow.millitm - volInfo->lastTimeCalledProgress.millitm >= 100)
> ++ if(timeNow.tv_sec - volInfo->lastTimeCalledProgress.tv_sec >= 1 ||
> ++ timeNow.tv_usec - volInfo->lastTimeCalledProgress.tv_usec >= 100)
Wait. You are changing "at least 100 milliseconds have passed" into
"at least 100 microseconds have passed".
> + gotGoodChar = false;
> + while(!gotGoodChar)
> + {
> ++#ifdef HAVE_ARC4RANDOM
> ++ oneRandomChar = arc4random();
> ++#else
> + oneRandomChar = random();
> ++#endif
> + if(64 < oneRandomChar && oneRandomChar < 91)
> + {
> + gotGoodChar = true;
That whole loop could be rewritten as just
oneRandomChar = arc4random_uniform('Z'-'A'+1) + 'A';
or some such.
--
Christian "naddy" Weisgerber [email protected]
