On 2013/12/22 03:15, Predrag Punosevac wrote:
> I noticed that Rafael Sadowski was working on x2goclient
> 
> https://github.com/jasperla/openbsd-wip/blob/master/x11/x2goclient/Makefile
> 
> Are there any serious technical obstacles to commit the port? Due to
> the fact that NX is no completely proprietary and close source and in
> the light of my rather poor experience with FreeNX server I started
> completely switching to X2Go.
> 

the biggest issue is listed in TODO..

| PKGNAME =                x2goclient-${VERSION}
| DISTNAME =                x2goclient-${VERSION}

just set DISTNAME

| # GPL2

use "GPLv2+" or "GPLv2 only" depending on whether it's v2-or-newer or v2-only

| LIB_DEPENDS =                x11/nx/nxproxy \
|                         security/libssh \
|                         x11/qt4 \
|                         databases/openldap \
|                         print/cups

cups libs are now in the -libs subpackage

| BUILD__DEPENDS =        x11/nx/nxproxy \

broken line, should only be one _

| do-install:
|         ${INSTALL} ${WRKSRC}/x2goclient ${PREFIX}/bin

should be INSTALL_PROGRAM

(and whitespace in the port Makefile is not to usual standards)

Reply via email to