2014-02-10 11:36 GMT+04:00 Antoine Jacoutot <[email protected]>:
> On Sun, Feb 09, 2014 at 09:04:21PM +0400, Vadim Zhukov wrote:
>> Unhardcode /var and zap an extra newline in PLIST. Should the latter
>> be warned by portcheck?
>>
>> Packaged fine on i386. Okay?
>
> I don't like this.
> First, LOCALSTATEDIR is something that is passed to CONFIGURE_ARGS and I
> don't see why it needs to be changed here.
> Use DBDIR=${VARBASE}/db/fookebox or something similar -- but do not play with
> LOCALSTATEDIR for no reason.
> Also that will give a wrong example; lots of ports uses $localestatedir as a
> top level for /var (think $localestatedir/run ...).
Good points, thank you. I'll cook and present a better patch after unlock then.
>> Index: Makefile
>> ===================================================================
>> RCS file: /cvs/ports/audio/fookebox/Makefile,v
>> retrieving revision 1.6
>> diff -u -p -r1.6 Makefile
>> --- Makefile 22 Jan 2014 00:18:45 -0000 1.6
>> +++ Makefile 9 Feb 2014 17:00:42 -0000
>> @@ -4,7 +4,7 @@ COMMENT= jukebox frontend to mpd
>>
>> MODPY_EGG_VERSION= 0.6.1
>> DISTNAME= fookebox-${MODPY_EGG_VERSION}
>> -REVISION= 3
>> +REVISION= 4
>> CATEGORIES= audio www
>>
>> HOMEPAGE= https://fookebox.googlecode.com/
>> @@ -27,6 +27,9 @@ RUN_DEPENDS= audio/py-mpd \
>> www/py-routes>=1.12.3
>>
>> NO_TEST= Yes
>> +
>> +LOCALSTATEDIR= ${BASELOCALSTATEDIR}/db/fookebox
>> +SUBST_VARS+= LOCALSTATEDIR
>>
>> post-install:
>> ${INSTALL_DATA_DIR} ${PREFIX}/share/{doc,examples}/fookebox/
>> Index: pkg/PLIST
>> ===================================================================
>> RCS file: /cvs/ports/audio/fookebox/pkg/PLIST,v
>> retrieving revision 1.2
>> diff -u -p -r1.2 PLIST
>> --- pkg/PLIST 15 Oct 2012 13:53:56 -0000 1.2
>> +++ pkg/PLIST 9 Feb 2014 17:00:42 -0000
>> @@ -142,5 +142,4 @@ share/examples/fookebox/config.ini
>> @sample ${SYSCONFDIR}/fookebox/config.ini
>> share/examples/fookebox/fookebox.fcgi
>> share/examples/fookebox/fookebox.wsgi
>> -@sample /var/db/fookebox/
>> -
>> +@sample ${LOCALSTATEDIR}/
>> Index: pkg/README
>> ===================================================================
>> RCS file: /cvs/ports/audio/fookebox/pkg/README,v
>> retrieving revision 1.2
>> diff -u -p -r1.2 README
>> --- pkg/README 15 Oct 2012 13:53:56 -0000 1.2
>> +++ pkg/README 9 Feb 2014 17:00:42 -0000
>> @@ -18,7 +18,7 @@ please use the command below:
>>
>> Adjust the configuration if needed. Create the initial database with:
>>
>> - touch /var/db/fookebox/fookebox.sqlite
>> + touch ${LOCALSTATEDIR}/fookebox.sqlite
>>
>> Now setup the application:
--
WBR,
Vadim Zhukov
