On Sun, Mar 30, 2014 at 05:55:30PM +0400, Sergey Bronnikov wrote: > p5-Moo is minimalist object orientation with Moose compatibility.
In general, these look ok. Did find some things that need fixing first. The newer version updates are optional but would make the script to help update DBIx::Class happier. https://gist.github.com/afresh1/7517222 Many of the DESCR files are rather slim and the one for p5-ExtUtils-BuildRC is completely wrong. Usually you don't need BUILD_DEPENDS=${RUN_DEPENDS} in perl modules. They generally build fine without, it just adds overhead that isn't necessary. These seemed to work fine without in my testing. I don't see p5-Import-Into included in this email and p5-Moo requires it. I grabbed it from openbsd-wip and that too seemed ok although there is a newer version (to support perl 5.6!) on the CPAN. There are already ports for p5-File-Find-Rule and p5-File-Slurp. ExtUtils::InstallPaths needs ExtUtils::Config as a RUN_DEPENDS Class-Method-Modifiers looks weird with a Test:: module in BUILD_DEPENDS. From the meta.yml it seems like those things probably just need to be in TEST_DEPENDS. File-Find-Rule could be updated to 0.33 if you want, and you could take maintainership, but a patch would be preferred. ExtUtils-Config is up to 0.007 which seems to have some nice improvements. ExtUtils-Helpers is now at 0.022, nothing that looked important but seems nicer. ExtUtils-InstallPaths has a small update to 0.010. Role-Tiny is now at 1.003003 and seems to be a bugfix. Role-Tiny needs Test::Fatal in TEST_DEPENDS l8rZ, -- andrew - http://afresh1.com ($do || !$do) && undef($try) ; # Master of Perl, Yoda is. Hmmmm? diff -ru orig/devel/p5-Class-Method-Modifiers/Makefile ports/devel/p5-Class-Method-Modifiers/Makefile --- orig/devel/p5-Class-Method-Modifiers/Makefile Sun Mar 30 06:25:09 2014 +++ ports/devel/p5-Class-Method-Modifiers/Makefile Sun Mar 30 15:18:42 2014 @@ -11,15 +11,13 @@ # Perl PERMIT_PACKAGE_CDROM = Yes -BUILD_DEPENDS = devel/p5-Test-Fatal \ - devel/p5-Try-Tiny - TEST_DEPENDS = devel/p5-ExtUtils-BuildRC \ devel/p5-ExtUtils-Config \ devel/p5-ExtUtils-InstallPaths \ devel/p5-File-Find-Rule \ devel/p5-File-Slurp \ devel/p5-Test-Fatal \ + devel/p5-Try-Tiny \ converters/p5-JSON .include <bsd.port.mk> diff -ru orig/devel/p5-ExtUtils-BuildRC/Makefile ports/devel/p5-ExtUtils-BuildRC/Makefile --- orig/devel/p5-ExtUtils-BuildRC/Makefile Sun Mar 30 04:26:56 2014 +++ ports/devel/p5-ExtUtils-BuildRC/Makefile Sun Mar 30 15:59:41 2014 @@ -13,6 +13,4 @@ RUN_DEPENDS = devel/p5-ExtUtils-Helpers -BUILD_DEPENDS = ${RUN_DEPENDS} - .include <bsd.port.mk> diff -ru orig/devel/p5-ExtUtils-InstallPaths/Makefile ports/devel/p5-ExtUtils-InstallPaths/Makefile --- orig/devel/p5-ExtUtils-InstallPaths/Makefile Sun Mar 30 04:29:15 2014 +++ ports/devel/p5-ExtUtils-InstallPaths/Makefile Sun Mar 30 15:52:26 2014 @@ -11,4 +11,6 @@ # Perl PERMIT_PACKAGE_CDROM = Yes +RUN_DEPENDS = devel/p5-ExtUtils-Config + .include <bsd.port.mk> Only in orig/devel: p5-File-Find-Rule Only in orig/devel: p5-File-Slurp Only in ports/devel: p5-Import-Into diff -ru orig/devel/p5-Role-Tiny/Makefile ports/devel/p5-Role-Tiny/Makefile --- orig/devel/p5-Role-Tiny/Makefile Tue Mar 11 10:31:33 2014 +++ ports/devel/p5-Role-Tiny/Makefile Sun Mar 30 11:40:56 2014 @@ -12,4 +12,6 @@ # Perl PERMIT_PACKAGE_CDROM = Yes +TEST_DEPENDS = devel/p5-Test-Fatal + .include <bsd.port.mk> diff -ru orig/devel/p5-strictures/Makefile ports/devel/p5-strictures/Makefile --- orig/devel/p5-strictures/Makefile Mon Mar 17 05:08:05 2014 +++ ports/devel/p5-strictures/Makefile Sun Mar 30 16:00:08 2014 @@ -15,6 +15,4 @@ RUN_DEPENDS = devel/p5-indirect -BUILD_DEPENDS = ${RUN_DEPENDS} - .include <bsd.port.mk>
