On Sat, Apr 26, 2014 at 05:31:46PM -0700, Andrew Fresh wrote:
> +MAINTAINER = Andrew Fresh <[email protected]>

Tab after =

> +MAKE_ENV =   TEST_POD=Yes \
>               PERL_TEST_CRITIC=Yes
...
> +TEST_DEPENDS =       devel/p5-Package-Generator \
>               devel/p5-Test-Perl-Critic

The Test::Perl::Critic test has been removed.

> +RUN_DEPENDS =        devel/p5-Data-OptList \
> +             devel/p5-Params-Util \
> +             devel/p5-Sub-Install

Malkefile.PL says:
    "Data::OptList" => "0.100",
    "Params::Util" => "0.14",
    "Sub::Install" => "0.92",

I find it easier to add these version numbers with >= to the port
dependencies.  Without the numbers there, the reviewer has to check
ports/INDEX wether our packages are new enough.  When the numbers
in ports Makefile and perl Malkefile.PL match, the ports framework
does the check automatically.

otherwise OK bluhm@

Reply via email to