07.05.2014 21:29 пользователь "Ingo Schwarze" <[email protected]> написал:
>
> Hi Vadim,
>
> as it stands, the port is still not OK, but you are coming closer.
>
> Vadim Zhukov wrote on Sun, May 04, 2014 at 02:05:51PM +0400:
> > "Vadim Zhukov" <[email protected]>:
> >> 2014/1/24 Ingo Schwarze <[email protected]>:
>
> >>> USE_GROFF would be very unfortunate in a port of this kind,
> >>> and in addition to that, the license specifically forbids it.
>
> Really, you must remove USE_GROFF from the Makefile, even though
> that will break some of the pages. The license plainly doesn't
> allow distributing the manuals without distributing the source.
Hm-m-m, we could just distribute packaged source files somewhere under
/usr/local/share, can't we? IMHO, it's better to fill disk a bit more than
to provide incorrect info.
> >>> The relevant part of the POSIX-COPYRIGHT file reads:
> >>>
> >>> Redistribution of this material is permitted so long as this
> >>> notice and the corresponding notices within each POSIX manual
> >>> page are retained on any distribution, and the nroff source is
> >>> included. Modifications to the text are permitted so long as any
> >>> conflicts with the standard are clearly marked as such in the
> >>> text.
>
> That said, i think the comment
>
> # permissive, see POSIX-COPYRIGHT
>
> in the Makefile is misleading. The term "permissive" is normally
> used for BSD-style licenses, but this one is more like GPL.
> Make something like:
>
> # custom copyleft license, see POSIX-COPYRIGHT
Agree, will be fixed.
> [...]
> >>> Do not install these manuals to /usr/local/man/,
> >>> but to a dedicated directory, something like
> >>> /usr/local/share/doc/posix/man/man{1,3}/*.{1,3}
>
> You have chosen:
>
> share/doc/man-pages-posix/man/man{1,3}/*.{1,3}
>
> Looking again, i think it is better to shorten this to
>
> share/doc/man-pages-posix/man{1,3}/*.{1,3}
Nice idea, thanks. Will be changed.
> [...]
> >>> Of course, a README would be OK with me, too.
>
> The README needs a few improvements:
>
> * I don't like the reasoning in the first sentence, i think it
> misses the point. Maybe something like:
> "Because the manuals contained in this package do not match
> any real software installed, they are not installed into
> directories that man(1) searches by default."
>
> * "You're promised" in the second sentence is not correct English.
> You might say:
> "Consider adding something like this..."
>
> * The final note should also be reworded, this is not specific
> to OpenBSD at all. Maybe like this:
> "Because manual page handling tools do not support section 0,
> header documentation is installed into section 3."
>
> There are also some issues with the DESCR:
>
> * The string "POSIX 1003.1-2013" is imprecise. You should say:
> "This package contains the IEEE Std 1003.1-2008 (POSIX.1)
> manual pages including the corrections contained in
> the first Technical Corrigendum, IEEE Std 1003.1-2008/Cor 1-2013."
>
> * The directories in the second sentence are wrong, and i don't
> see the point in listing them at all. Maybe:
> "It include manuals for utilities in section 1 and for functions
> and headers in section 3."
>
> So far, that's all from visual inspection. I think this needs
> another iteration before it makes sense to start with actual testing.
Got it.
> Thanks for working on this,
Thank you for reviewing. I'll send you updated port as it'll be ready.
