On Mon, Jun 2, 2014 at 1:00 PM, Stuart Henderson <[email protected]> wrote: > On 2014/06/01 18:06, viq wrote: >> By popular request ;) Here's an update to 0.8.16. Seems to work for me, >> though there's a bunch of warnings when compiling. >> >> Possibly the patching of src/core/network-openssl.c is not necessary to >> add static int getpass_cb on line 423 - there is a similiar function >> below in line 445 called static int get_pem_password_callback. It would >> be great if someone who actually knows C would have a look at it. > > getpass_cb() isn't referenced anywhere else so it's just dead code, > the functionality was included in upstream's recent commit where they > added certificate password support themselves. > > I've pulled this patch out in the copy in my tree, things work fine > here, I intend to commit it fairly soon unless there are objections. >
For what it's worth (little ;) I don't have any objections. -- viq
