Hi Stuart,
Marc Espie convinced me that pkg_add(1) is the only use case
of the -d and -u flags of makewhatis(8) that matters in practice,
and the code path you are touching here is only used by -d and -u.
So contrary to my earlier impression, and after some testing and
code inspection, this is
ok schwarze@
Yours,
Ingo
Stuart Henderson wrote on Tue, Jun 17, 2014 at 10:41:16PM +0100:
> Index: mandocdb.c
> ===================================================================
> RCS file: /cvs/src/usr.bin/mandoc/mandocdb.c,v
> retrieving revision 1.107
> diff -u -p -r1.107 mandocdb.c
> --- mandocdb.c 5 Jun 2014 07:13:53 -0000 1.107
> +++ mandocdb.c 17 Jun 2014 21:39:53 -0000
> @@ -2223,7 +2223,8 @@ dbopen(int real)
> rc = sqlite3_open_v2(MANDOC_DB, &db, ofl, NULL);
> if (SQLITE_OK != rc) {
> exitcode = (int)MANDOCLEVEL_SYSERR;
> - say(MANDOC_DB, "%s", sqlite3_errstr(rc));
> + if (SQLITE_CANTOPEN != rc)
> + say(MANDOC_DB, "%s", sqlite3_errstr(rc));
> return(0);
> }
> goto prepare_statements;
