Thanks a lot for your feedback Anthony!

I can see that you put a "USE_GROFF = Yes" line in - is this
intentional?

Also, does it still need a MAINTAINER line? I can see that it's gone
from your version.

On Sat, Jun 28, 2014, at 02:03 AM, Anthony J. Bentley wrote:
> Vasily Mikhaylichenko writes:
> > I've just ported the CellWriter input panel / on-screen keyboard:
> > 
> > CellWriter is a grid-entry natural handwriting input panel.
> > Writer-dependent, CellWriter learns your handwriting for reliable
> > recognition. Correcting preprocessor algorithms account for digitizer
> > noise, differing stroke order, direction, and number of strokes. Unicode
> > support enables you to write in any language.
> > 
> > Builds and works for me on amd64, -current. I am using it on a Lenovo
> > x230 tablet.
> > 
> > Comments appreciated.
> 
> COMMENT should not be capitalized.
> 
> I would put it in the inputmethods category as well.
> 
> License is GPLv2+, not GPLv2.
> 
> Common practice with wantlib is to use "WANTLIB += foo" instead of
> indenting, so that future updaters can just paste in output from
> port-lib-depends-check without it looking inconsistent.
> 
> MASTER_SITES leads to a 301 redirect, usually best to use the final
> destination in that case (one less link to break).
> 
> Missing GTK icon goo.
> 
> Doesn't need USE_GROFF.
> 
> Other than the above, it looks good to me. I've attached a version with
> those changes. Anyone willing to ok so I can import?
> 
> -- 
> Anthony J. Bentley
> Email had 1 attachment:
> + cellwriter.tar.gz
>   2k (application/x-gzip)

Reply via email to