On Sun, Jul 13, 2014 at 04:37:18PM +0200, Vadim Zhukov wrote:
> 2014-07-13 15:50 GMT+02:00 Giovanni Bechis <[email protected]>:
> > On Sat, Jul 12, 2014 at 08:22:12AM -0700, Andrew Fresh wrote:
> >> Hurray! Finally ready to send this in!
> >>
> >> So many fixes, but most interesting to me is the rewrite of the result
> >> constructor that makes things significantly faster.
> >>
> >> https://metacpan.org/source/RIBASUSHI/DBIx-Class-0.08270/Changes
> >>
> >> All regression tests pass including TEST_MYSQL and TEST_PG.
> >>
> >> I did @comment dbicadmin as we don't currently have a port of
> >> p5-MooseX-Types-JSON which it requires so better to not install it.
> >>
> >> Also take maintainership.
> >>
> >> OK?
> >>
> > if TEST_MYSQL or TEST_PG are enabled regression tests will become
> > interactive,
> > it is also worth to comment dbicadmin.1 as well.
> > Otherwise ok.
>
> Does "interactive" means "wants server up and running"? If just that,
> it could be done in port, like I did it recently for
> databases/libpqxx.
>
for mysql it could be difficult, `mysqladmin create $DB` cannot specify where
to create the database and, once dropped, there is no "vacuum"
feature to reclaim space used in innodb tablespace.
Cheers
Giovanni
