On 2014/07/18 21:16, Fabian Raetz wrote: > On Thu, Jul 17, 2014 at 11:56:24PM +0100, Stuart Henderson wrote: > > On 2014/07/17 22:23, Fabian Raetz wrote: > > > Hi, > > > > > > I would like to see a wireshark.desktop file and icons added. > > > > > > Initial inspiration based on the archlinux package. > > > https://projects.archlinux.org/svntogit/community.git/tree/trunk/PKGBUILD?h=packages/wireshark > > > > > > Comments? > > > > For ease of future maintenance (for example if upstream move > > files around in their source tree), I'd prefer to use the provided > > install_desktop_files target rather than having all of this in > > post-install. > > > > They install to wrong directories but these can simply be dealt with > > by mv'ing into place in post-install using wildcards (which is easier > > to maintain than patching Makefile.in). > > > Hey Stuart, > > i cooked a new patch based on your feedback, but not without patching > Makefile.in :( > > More Feedback welcome.
Thanks, I've committed this and fed the patch upstream. > Not related to this patch but i had some old libkrb libs lying around o0 and > they got picked up by wireshark ... would it be a good idea to explicitly > disable > krb in the Makefile? IIRC the consensus was not to do this in ports, there are various sorts of exciting ways things can break if the upgrade docs aren't followed and this is one of the less bad ones ;)
