On Wed, Aug 20, 2014 at 01:19:57PM +0200, Manuel Giraud wrote:
> Here is an update to klavaro tested on 5.5 i386. This version is bundle
> with its own gtkdatabox library so I made it conflict with gtkdatabox
> package. I also had to patch the configure script because
> *_required_version variables weren't replaced with actual version
> number: i don't know if there is a better way here.

Some nits:

it should first try to use the existing gtkdatabox library. Really.

if it *really* cant, make it install it somewhere where other things
needing gtkdatabox cant find it to avoid hazardous builds

in that case you need a SHARED_LIBS entry for the library.

REVISION is not needed.

Please update the PLIST again, the LC_MESSAGE dirs shouldnt be readded
imho. As for the configure script, either bug upstream with it, or run
autoconf to regenerate it.

Landry

Reply via email to