On Wed, Oct 22, 2014 at 04:45:26PM +0200, Pierre-Emmanuel André wrote:
> Hi,
>
> Small diff to update zsh to it's latest version.
> Tested on @amd64.
>
> Comments, ok ?
> Regards,
>
This looks good to me (also amd64). I've been running the updated shell for
about a day now and didn't encounter any issues.
Two comments:
1. I went through the entire list on the ports testing guide and almost
everything seems to be fine. There still is this spurious failure
of ``make test'' which ends with
**************************************
42 successful test scripts, 1 failure, 0 skipped
**************************************
*** Error 1 in Test (Makefile:204 'check')
*** Error 1 in /usr/obj/ports/zsh-5.0.7/zsh-5.0.7 (Makefile:265 'check')
*** Error 1 in . (/usr/ports/infrastructure/mk/bsd.port.mk:2801
'/usr/obj/ports/zsh-5.0.7/.test_done')
*** Error 1 in /usr/ports/shells/zsh
(/usr/ports/infrastructure/mk/bsd.port.mk:2492 'test')
after indicating that _all_ tests passed successfully. This bizarre brekage
has been around for a while now.
2. The following simple patch fixes a compiler warning in
Src/Modules/langinfo.c
Index: patches/patch-Src_Modules_langinfo_c
===================================================================
RCS file: patches/patch-Src_Modules_langinfo_c
diff -N patches/patch-Src_Modules_langinfo_c
--- /dev/null 1 Jan 1970 00:00:00 -0000
+++ patches/patch-Src_Modules_langinfo_c 23 Oct 2014 10:54:35 -0000
@@ -0,0 +1,13 @@
+$OpenBSD$
+--- Src/Modules/langinfo.c.orig Wed Nov 27 20:00:20 2013
++++ Src/Modules/langinfo.c Thu Oct 23 12:52:37 2014
+@@ -395,7 +395,8 @@ liitem(const char *name)
+ static HashNode
+ getlanginfo(UNUSED(HashTable ht), const char *name)
+ {
+- int len, *elem;
++ nl_item *elem;
++ int len;
+ char *listr, *nameu;
+ Param pm = NULL;
+
