On Sun, Nov 02, 2014 at 10:20:44AM +0000, Stuart Henderson wrote: > On 2014/11/02 00:13, Jan Klemkow wrote: > > Hi, > > > > this is gatling a small and fast http/file server. It depends on > > devel/libowfat which is not in ports yet. > > > > Please, tell me everything that is not ok. I will fix it. > > > > thanks, > > Jan > > - same comment as libowfat re: license marker and overriding makefile > variables
done
> - libiconv should use the module rather than BUILD_DEPENDS
done
> - daemons should be in sbin not bin
done
> - should use the user-supplied CFLAGS (in particular things like
> "make DEBUG=-g" and "make CFLAGS=-O0" should work), passed in via
> MAKE_FLAGS.
done
> - don't hardcode /usr/local. easiest way is to pass in ${LOCALBASE}
> via MAKE_FLAGS (otherwise you need to patch and use SUBST_CMD).
done
> - don't strip shared libraries (-s in LDFLAGS)
done
> - BUILD_DEPENDS on libowfat ... hmm ... ah I see, there is no shared
> library for libowfat. If it's not possible to produce a shared lib,
> then gatling would need a REVISION bump whenever libowfat is updated.
It is a design decision by the developer of gatling to make libowfat
static. I don't want to break his design here. I will keep it in mind
to bump the REVISION by libowfat updates.
Thanks,
Jan
gatling.tar.gz
Description: application/tar-gz
