> From: Stuart Henderson <st...@cvs.openbsd.org>
> Date: Wed, Nov 12, 2014 at 2:19 PM
> Subject: Re: CVS: cvs.openbsd.org: ports
> To: David Coppa <dco...@gmail.com>
> Cc: ports-chan...@cvs.openbsd.org
>
>
> On 2014/11/12 14:11, David Coppa wrote:
> > On Wed, Nov 12, 2014 at 1:34 PM, Stuart Henderson <st...@cvs.openbsd.org>
> > wrote:
> > > CVSROOT: /cvs
> > > Module name: ports
> > > Changes by: st...@cvs.openbsd.org 2014/11/12 05:34:07
> > >
> > > Modified files:
> > > graphics/darktable: Makefile
> > >
> > > Log message:
> > > reinstate compiler flags to unbreak i386
> > >
> >
> > What's the missing flag that broke the i386 build?
>
> It definitely needs some SSE flags, I haven't tried all the various
> possibilities.
This is the minimum required to have darktable work on both i386
and amd64:
Index: Makefile
===================================================================
RCS file: /cvs/ports/graphics/darktable/Makefile,v
retrieving revision 1.42
diff -u -p -u -p -r1.42 Makefile
--- Makefile 12 Nov 2014 12:34:07 -0000 1.42
+++ Makefile 14 Nov 2014 10:45:04 -0000
@@ -14,7 +14,7 @@ COMMENT= virtual lighttable and darkroom
# N.B. newer versions require TLS
DISTNAME= darktable-1.2.3
EXTRACT_SUFX= .tar.xz
-REVISION= 3
+REVISION= 4
SHARED_ONLY= Yes
@@ -67,10 +67,14 @@ SEPARATE_BUILD= Yes
USE_GROFF= Yes
CONFIGURE_ARGS= -DOPENJPEG_INCLUDE_DIR=${PREFIX}/include/openjpeg-1.5 \
- -DBINARY_PACKAGE_BUILD=1
+ -DBINARY_PACKAGE_BUILD=1 \
+ -DCUSTOM_CFLAGS=1
# enable workaround for mutex problems
CFLAGS+= -D_DEBUG
+
+# error: #error "SSE instruction set not enabled"
+CFLAGS+= -msse2
CPPFLAGS+= -I${LOCALBASE}/include
LDFLAGS+= -L${LOCALBASE}/lib
Index: patches/patch-src_CMakeLists_txt
===================================================================
RCS file: patches/patch-src_CMakeLists_txt
diff -N patches/patch-src_CMakeLists_txt
--- patches/patch-src_CMakeLists_txt 12 Nov 2014 12:37:06 -0000 1.3
+++ /dev/null 1 Jan 1970 00:00:00 -0000
@@ -1,16 +0,0 @@
-$OpenBSD: patch-src_CMakeLists_txt,v 1.3 2014/11/12 12:37:06 sthen Exp $
-
-Disable -Werror to prevent failing compilation when using deprecated
-functions from libgnome-keyring
-
---- src/CMakeLists.txt.orig Wed Nov 12 12:36:22 2014
-+++ src/CMakeLists.txt Wed Nov 12 12:36:33 2014
-@@ -315,7 +315,7 @@ if(NOT CUSTOM_CFLAGS)
- if(NOT APPLE AND NOT CMAKE_C_COMPILER_ID STREQUAL "Clang")
- # apple build fails on deprecated warnings..
- # and too many warnings reported by Clang for now
-- set(CMAKE_C_FLAGS "${CMAKE_C_FLAGS} -Werror")
-+ #set(CMAKE_C_FLAGS "${CMAKE_C_FLAGS} -Werror")
-
- # gcc-4.8 build fails on unused local typedefs in gmacros.h:162
- # to be removed when glib will get fixed
