Le 22/11/2014 23:28, Stuart Henderson a écrit :
> - don't include REVISION (that is added if the port is changed after
> committing)
>
> - missing license marker should be "GPLv2 only" unless it changed since 0.8.4
>
> - MAINTAINER should be Name <email>
>
> - IMHO, DESCR should keep the Terry Pratchett reference ;-)
> (DESCR doesn't need to talk about the license though).
>
> - PLIST should be sorted, doc/ before examples/
>
Should be fixed (please find the URL at the bottom).
> - I don't see why you had to set CC/CXX, these are the very same programs
> as the default cc/c++, and in any event they should not be hardcoded
>
> $ ls -li /usr/bin/{cc,gcc,c++,g++}
> 132370 -r-xr-xr-x 2 root bin 201912 Nov 20 07:40 /usr/bin/c++
> 132372 -r-xr-xr-x 2 root bin 199704 Nov 20 07:40 /usr/bin/cc
> 132370 -r-xr-xr-x 2 root bin 201912 Nov 20 07:40 /usr/bin/g++
> 132372 -r-xr-xr-x 2 root bin 199704 Nov 20 07:40 /usr/bin/gcc
>
> it builds ok without this line for me.
>
Hummm, my mistake.
I think that I did this during my tests before I had "USE_LIBTOOL=gnu".
I saw that the binaries was the same but I guessed there was a behavior
difference depending on the name used to call them.
> - in general we don't use /var/lib on OpenBSD. the files that dibbler
> has in there seem to be a mixture of things we'd have in /var/db,
> /var/run (pid files) and maybe others. I think that is probably about
> the point I postponed work on this last time ;)
>
It should be fixed; I hope it will be clean enough for you.
For now I only did few tests on the client; if you agree with the method
I will do more tests for both packages.
> - USE_LIBTOOL=gnu is very much for special cases and should have a
> comment explaining why it's used. or even better see if it can be fixed,
> the old version didn't need this.
>
> ./ClntIfaceMgr/libClntIfaceMgr.a(libClntIfaceMgr_a-ClntIfaceMgr.o)(.text+0x348c):
> In function `TClntIfaceMgr::select(unsigned int)':
> : undefined reference to `TClntMsgReply::TClntMsgReply(int, SPtr<TIPv6Addr>,
> char*, int)'
> ./ClntIfaceMgr/libClntIfaceMgr.a(libClntIfaceMgr_a-ClntIfaceMgr.o)(.text+0x35f3):
> In function `TClntIfaceMgr::select(unsigned int)':
> : undefined reference to `TClntMsgReconfigure::TClntMsgReconfigure(int,
> SPtr<TIPv6Addr>, char*, int)'
> collect2: ld returned 1 exit status
>
Ok, here come the tricky part for me.
I will get back to you with some clues (hopefully).
Here is the new release:
http://c.mxher.fr/dibbler-1.0.0_01.tgz
Thanks Stuart.
Mxher
