On Mon, 12 Jan 2015 02:08:04 +0100 [email protected] (Jérémie Courrèges-Anglas) wrote: > Landry Breuil <[email protected]> writes: >> On Mon, Jan 12, 2015 at 05:04:32AM +0900, YASUOKA Masahiko wrote: >>> On Sun, 11 Jan 2015 20:30:42 +0100 >>> Landry Breuil <[email protected]> wrote: >>> > On Mon, Jan 12, 2015 at 03:36:01AM +0900, YASUOKA Masahiko wrote: >>> >> I'd like to add 'iwatch' to our ports. >>> >> >>> >> iwatch is "interval watch", it shows the command output periodically >>> >> and makes the changed words, lines or characters be highlighted so that >>> >> the changes can be monitored easily. BSD/OS had a simillar command, >>> >> named watch(1), and linux also has watch(1). >>> >> >>> >> iwatch was developed by IIJ (company I'm working for) and had been >>> >> used in IIJ for long time. Currently it is maintained at >>> >> github.com/iij/iwatch by myself. >>> > >>> > Since you're fetching code from github, you should use the various GH_* >>> > vars for consistency.. see lots of other ports for example, right now >>> > only geo/mapproxy comes to my mind :) >>> >>> I didn't know GH_* since I refered wrong version's ports.. Thanks, >>> >>> Update the tar.gz >>> >>> ok? >> >> Dont hardcode usr/local, use $PREFIX or $TRUEPREFIX or $LOCALBASE >> depending on the situation... see bsd.port.mk. Other than that reads ok. > > Same here. There's a bug shown by strong malloc settings, though. > (ln -s S /etc/malloc.conf on amd64)
I read bsd.port.mk(5). Replaced usr/local to $PREFIX. > The following patch fixes it. When initially allocating s and thus > cmdstr we need to make sure that it is a NUL-terminated string. Updated iwatch to 1.0.2. I'll commit the attached tar.gz. Thanks. --yasuoka
iwatch.tar.gz
Description: Binary data
