Bruno Flueckiger <[email protected]> writes: > On 16.01.2015 01:29, Jérémie Courrèges-Anglas wrote: >> >> I would zap it too. But feel free to discuss this with upstream and >> work with them to use the safer strl idiom. :) >> Even though this API is safer people have done mistakes in ports in the >> past. >> >> Please also use http://www.udpxy.com/index-en.html as homepage. >> > > Thanks for your feedback, Jérémie. I've changed the homepage in > Makefile, removed the patches strncpy() -> strlcpy() and kept the patch > strcpy() -> strlcpy().
*shrug*. No objection about the latter since it looks correct.
> Attached is the updated port. Any feedback is welcome!
Improved version:
* respect CFLAGS
* use a dedicated group instead of the default "daemon"
* don't hardcode /var/log in udpxy.rc but use ${LOCALSTATEDIR}
* while here use the same default port as FreeBSD, else there is no
point setting default daemon_flags
* ensure that we have a writable directory for the logfile in
${LOCALSTATEDIR}/log. @mode annotations for paranoia, they can go
away if people think they're useless
I don't have a way to test this in the field. I think this version is
ready to go in, depending on the feedback and tests.
What do you folks think?
udpxy.tgz
Description: Binary data
-- jca | PGP : 0x1524E7EE / 5135 92C1 AD36 5293 2BDF DDCC 0DFA 74AE 1524 E7EE
