On Tue, Mar 24, 2015 at 10:44:52AM -0700, Eric Lalonde wrote: > On Mar 15, 2015, at 6:20 PM, Eric Lalonde <[email protected]> wrote: > > > On Mar 15, 2015, at 12:33 PM, Landry Breuil <[email protected]> wrote: > > > >> On Sun, Mar 15, 2015 at 12:27:35PM -0700, Eric Lalonde wrote: > >>> Hello ports@, > >>> > >>> databases/barman has been updated to 1.4.0. Changes include improvements > >>> to > >>> incremental backup and bugfixes to retention policies. > >>> > >>> Announcement with more information is available at > >>> http://www.postgresql.org/about/news/1566/ > >>> > >>> This software currently has no maintainer; I am offering to be maintainer, > >>> which this diff reflects. > >>> > >>> Please note that while preparing this diff I encountered the FULLPKGNAME\- > >>> issue in make-plist(1) that was discussed in > >>> http://marc.info/?l=openbsd-ports&m=136853948729478. When I applied > >>> Samir's > >>> patch mentioned in that thread, the problem was resolved. Is that patch > >>> still up for consideration? > >> > >> make plist is somewhat broken, it should just be used as an aid, but > >> you'll have to hand-edit the PLIST anyway. There's some useless churn in > >> the PLIST in your diff (moving @mode around, etc) and you should > >> preserve barman-${MODPY_EGG_VERSION} otherwise it will fail to package > >> when REVISION is bumped. > > > > Thanks for the feedback and cluesticks, updated diff attached. Re-tested on > > amd64. > > Ping.
One minor nit: I'll add NO_TEST=Yes since tests_require in setup.py lists (in addition to the regular runtime depends argh/argcomplete...) pytest and mock (for which we have ports) but also pytest-capturelog and pytest-timeout for which we have no ports. Landry
