attila <[email protected]> writes:
> attila <[email protected]> writes:
>
>> textproc/py-lxml was at 3.3.5, which is a year old. I needed a more
>> recent release, so I have an update that brings us to 3.4.3 (released
>> 15-APR-2015), attached.
>>
>> The only changes are the single edit I made to bring us to version
>> 3.4.3 and those introduced by makesum and update-plist, which
>> magically s/py-/\${MODPY_PY_PREFIX}/'ed everywhere; I presume that's
>> right?
"It works" but it isn't right. For now I suggest that you use
make-plist, but replace ${MODPY_PY_PREFIX} with your text editor.
The problem will probably get solved automatically when we'll add
a python3 FLAVOR. Because then you'd have to run "make-plist" with the
python3 FLAVOR, and py-lxml won't be replaced by ${MODPY_PY_PREFIX}.
But that would be for another diff.
> bcallah@ pointed out that I forgot to get rid of REVISION.
> While I'm at it I'll add myself as MAINTAINER.
No objection from me.
> Updated patch appended.
>
>> Tested lightly on amd64....
>
> Now also tested on i386.
>
> Comments, feedback welcome.
Diff addressing the issue above plus the following nits:
- EXTRACT_SUFX is not needed
- please put MAINTAINER in its usual place, between HOMEPAGE and
PERMIT_*. Some other entries could probably be moved too, but I did
not adress them yet.
- trailing whitespace in pkg/DESCR. Found by emacs and portcheck(1).
Regarding ''make test'':
- the current port failed 10 times out of 10, 2 of them due to a double
free error
- the proposed port failed 3 times out of 10, all of them due to
a double free error
Thoughts?
Index: Makefile
===================================================================
RCS file: /cvs/ports/textproc/py-lxml/Makefile,v
retrieving revision 1.22
diff -u -p -r1.22 Makefile
--- Makefile 17 Apr 2015 08:06:04 -0000 1.22
+++ Makefile 29 Apr 2015 11:31:20 -0000
@@ -3,19 +3,19 @@
COMMENT= Python binding for the libxml2 and libxslt libraries
BROKEN-hppa= OOM on src/lxml/lxml.etree.c
-MODPY_EGG_VERSION= 3.3.5
-REVISION= 0
+MODPY_EGG_VERSION= 3.4.3
DISTNAME= lxml-${MODPY_EGG_VERSION}
PKGNAME= py-lxml-${MODPY_EGG_VERSION}
CATEGORIES= textproc devel
HOMEPAGE= http://lxml.de/
+MAINTAINER = Sean Levy <[email protected]>
+
# BSD
PERMIT_PACKAGE_CDROM= Yes
MODPY_PI = Yes
-EXTRACT_SUFX= .tar.gz
WANTLIB= ${MODPY_WANTLIB} exslt m pthread xml2 xslt z
Index: distinfo
===================================================================
RCS file: /cvs/ports/textproc/py-lxml/distinfo,v
retrieving revision 1.8
diff -u -p -r1.8 distinfo
--- distinfo 5 Jun 2014 06:57:03 -0000 1.8
+++ distinfo 29 Apr 2015 11:30:31 -0000
@@ -1,2 +1,2 @@
-SHA256 (lxml-3.3.5.tar.gz) = ataUncfup0SjD7p3qWjdWRD1RSIOWLzIE7nfXHk+MYo=
-SIZE (lxml-3.3.5.tar.gz) = 3467344
+SHA256 (lxml-3.4.3.tar.gz) = bOShGrSFpnqJmqPggMl7IqnfQMcHe9kUaoIdOHLPIDc=
+SIZE (lxml-3.4.3.tar.gz) = 3541740
Index: pkg/DESCR
===================================================================
RCS file: /cvs/ports/textproc/py-lxml/pkg/DESCR,v
retrieving revision 1.1.1.1
diff -u -p -r1.1.1.1 DESCR
--- pkg/DESCR 3 Apr 2008 11:31:59 -0000 1.1.1.1
+++ pkg/DESCR 29 Apr 2015 11:33:02 -0000
@@ -1,6 +1,6 @@
-lxml is a Pythonic, mature binding for the libxml2 and libxslt libraries.
-It provides safe and convenient access to these libraries using the
+lxml is a Pythonic, mature binding for the libxml2 and libxslt libraries.
+It provides safe and convenient access to these libraries using the
ElementTree API.
-It extends the ElementTree API significantly to offer support for XPath,
+It extends the ElementTree API significantly to offer support for XPath,
RelaxNG, XML Schema, XSLT, C14N and much more.
Index: pkg/PLIST
===================================================================
RCS file: /cvs/ports/textproc/py-lxml/pkg/PLIST,v
retrieving revision 1.6
diff -u -p -r1.6 PLIST
--- pkg/PLIST 5 Jun 2014 06:57:03 -0000 1.6
+++ pkg/PLIST 29 Apr 2015 11:32:03 -0000
@@ -271,6 +271,7 @@ share/doc/py-lxml/html/api/lxml.etree._V
share/doc/py-lxml/html/api/lxml.etree._XPathEvaluatorBase-class.html
share/doc/py-lxml/html/api/lxml.etree._XSLTProcessingInstruction-class.html
share/doc/py-lxml/html/api/lxml.etree._XSLTResultTree-class.html
+share/doc/py-lxml/html/api/lxml.etree.htmlfile-class.html
share/doc/py-lxml/html/api/lxml.etree.iterparse-class.html
share/doc/py-lxml/html/api/lxml.etree.iterwalk-class.html
share/doc/py-lxml/html/api/lxml.etree.xmlfile-class.html
@@ -383,6 +384,10 @@ share/doc/py-lxml/html/api/lxml.tests.te
share/doc/py-lxml/html/api/lxml.tests.test_dtd-module.html
share/doc/py-lxml/html/api/lxml.tests.test_dtd-pysrc.html
share/doc/py-lxml/html/api/lxml.tests.test_dtd.ETreeDtdTestCase-class.html
+share/doc/py-lxml/html/api/lxml.tests.test_elementpath-module.html
+share/doc/py-lxml/html/api/lxml.tests.test_elementpath-pysrc.html
+share/doc/py-lxml/html/api/lxml.tests.test_elementpath.ElementTreeElementPathTestCase-class.html
+share/doc/py-lxml/html/api/lxml.tests.test_elementpath.EtreeElementPathTestCase-class.html
share/doc/py-lxml/html/api/lxml.tests.test_elementtree-module.html
share/doc/py-lxml/html/api/lxml.tests.test_elementtree-pysrc.html
share/doc/py-lxml/html/api/lxml.tests.test_elementtree.CElementTreeTestCase-class.html
@@ -413,8 +418,10 @@ share/doc/py-lxml/html/api/lxml.tests.te
share/doc/py-lxml/html/api/lxml.tests.test_incremental_xmlfile-module.html
share/doc/py-lxml/html/api/lxml.tests.test_incremental_xmlfile-pysrc.html
share/doc/py-lxml/html/api/lxml.tests.test_incremental_xmlfile.BytesIOXmlFileTestCase-class.html
+share/doc/py-lxml/html/api/lxml.tests.test_incremental_xmlfile.HtmlFileTestCase-class.html
share/doc/py-lxml/html/api/lxml.tests.test_incremental_xmlfile.SimpleFileLikeXmlFileTestCase-class.html
share/doc/py-lxml/html/api/lxml.tests.test_incremental_xmlfile.SimpleFileLikeXmlFileTestCase.SimpleFileLike-class.html
+share/doc/py-lxml/html/api/lxml.tests.test_incremental_xmlfile.TempPathXmlFileTestCase-class.html
share/doc/py-lxml/html/api/lxml.tests.test_incremental_xmlfile.TempXmlFileTestCase-class.html
share/doc/py-lxml/html/api/lxml.tests.test_incremental_xmlfile._XmlFileTestCaseBase-class.html
share/doc/py-lxml/html/api/lxml.tests.test_io-module.html
@@ -458,6 +465,7 @@ share/doc/py-lxml/html/api/lxml.tests.te
share/doc/py-lxml/html/api/lxml.tests.test_threading.ThreadingTestCase-class.html
share/doc/py-lxml/html/api/lxml.tests.test_unicode-module.html
share/doc/py-lxml/html/api/lxml.tests.test_unicode-pysrc.html
+share/doc/py-lxml/html/api/lxml.tests.test_unicode.EncodingsTestCase-class.html
share/doc/py-lxml/html/api/lxml.tests.test_unicode.UnicodeTestCase-class.html
share/doc/py-lxml/html/api/lxml.tests.test_xmlschema-module.html
share/doc/py-lxml/html/api/lxml.tests.test_xmlschema-pysrc.html
@@ -513,6 +521,7 @@ share/doc/py-lxml/html/api/toc-lxml.test
share/doc/py-lxml/html/api/toc-lxml.tests.test_css-module.html
share/doc/py-lxml/html/api/toc-lxml.tests.test_doctestcompare-module.html
share/doc/py-lxml/html/api/toc-lxml.tests.test_dtd-module.html
+share/doc/py-lxml/html/api/toc-lxml.tests.test_elementpath-module.html
share/doc/py-lxml/html/api/toc-lxml.tests.test_elementtree-module.html
share/doc/py-lxml/html/api/toc-lxml.tests.test_errors-module.html
share/doc/py-lxml/html/api/toc-lxml.tests.test_etree-module.html
--
jca | PGP : 0x1524E7EE / 5135 92C1 AD36 5293 2BDF DDCC 0DFA 74AE 1524 E7EE
