Hey, Thanks everyone for the input.
On Mon, May 18, 2015 at 09:24:32AM +0100, Stuart Henderson wrote:
> > Does anyone with mad cmake skills know how to get rid of the pre-configure
> > kludge?
>
> I wouldn't worry about that too much...file needs patching anyway so
> another chunk doesn't hurt :)
Dcoppa invoked mad cmake skills, and this is now fixed :)
> | # undefined reference to `SSL_CTX_set_psk_client_callback'
> | CONFIGURE_ARGS += -DWITH_TLS_PSK=no
>
> Pre-shared key support was intentionally removed from libressl.
Fixed.
> | MODULES = devel/cmake
> | USE_GMAKE = Yes
>
> really gmake? that is rather unusual for cmake ports.
Indeed. Fixed.
> | MANDIRS = 1 3 5 7 8
> ..
> | .for i in ${MANDIRS}
> | mv ${PREFIX}/share/man/man${i}/*.${i} ${PREFIX}/man/man${i}/
> | rmdir ${PREFIX}/share/man/man${i}
> | .endfor
> | rmdir ${PREFIX}/share/man
>
> probably cleaner to patch the cmake files and install in the right place
> in the first place
Fixed.
>
> | mkdir ${WRKINST}/${SYSCONFDIR}/mosquitto
>
> this isn't needed
Fixed.
> | daemon="/usr/local/sbin/mosquitto"
> | daemon_flags="-d -c /etc/mosquitto/mosquitto.conf"
>
> ${PREFIX}, ${SYSCONFDIR}. if "-d" is "daemonize" please move that
> from daemon_flags to daemon so that people changing mosquitto_flags in
> rc.conf.local don't have a risk of missing it out.
It is indeed 'daemonize'. Fixed.
> how about "mv ${PREFIX}/etc/mosquitto ${PREFIX}/share/examples/mosquitto"
> and then PLIST will just be share/examples/mosquitto/aclfile.example, etc?
Fixed.
>
> Also wants an @extra for the pid file, and go ahead and reserve a space
> in infrastructure/db/user.list.
And finally, fixed!
New tarball attached (also in openbsd-wip). OK?
--
Best Regards
Edd Barrett
http://www.theunixzoo.co.uk
mosquitto3.tgz
Description: application/tar-gz
